Skip to content

Node: Add XINFO GROUPS command. - #2122

Merged
Yury-Fridlyand merged 6 commits into
valkey-io:mainfrom
Bit-Quill:node/yuryf-xinfo-groups-valkey-58
Aug 16, 2024
Merged

Yury-Fridlyand merged 6 commits into
valkey-io:mainfrom
Bit-Quill:node/yuryf-xinfo-groups-valkey-58

Conversation

@Yury-Fridlyand

Copy link
Copy Markdown

No description provided.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the node 🐢 Node.js wrapper label Aug 12, 2024
@Yury-Fridlyand
Yury-Fridlyand requested a review from a team as a code owner August 12, 2024 22:14
Comment thread node/src/BaseClient.ts
GeoUnit,
GeospatialData,
InsertPosition,
KeyWeight, // eslint-disable-line @typescript-eslint/no-unused-vars

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm that this should be removed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to suppress this eslint check if we import a type to refer in docs. KeyWeight is used as a function argument, so we can remove it.

Comment thread node/src/BaseClient.ts Outdated
Comment thread node/src/BaseClient.ts
Comment thread node/src/BaseClient.ts Outdated
Comment thread node/tests/SharedTests.ts
"last-entry": (string | number | string[])[];
groups: number;
};
console.log(result);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment thread node/src/BaseClient.ts Outdated
Comment thread node/src/Transaction.ts Outdated
Yury-Fridlyand and others added 3 commits August 14, 2024 17:25
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Yury-Fridlyand merged commit 1195c82 into valkey-io:main Aug 16, 2024
@Yury-Fridlyand
Yury-Fridlyand deleted the node/yuryf-xinfo-groups-valkey-58 branch August 16, 2024 19:51
affonsov pushed a commit that referenced this pull request Aug 21, 2026
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

node 🐢 Node.js wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants