Skip to content

Node: Add ZRANGESTORE command - #2068

Merged
acarbonetto merged 12 commits into
valkey-io:mainfrom
Bit-Quill:node/integ_acarbo_zrangestore
Aug 9, 2024
Merged

acarbonetto merged 12 commits into
valkey-io:mainfrom
Bit-Quill:node/integ_acarbo_zrangestore

Conversation

@acarbonetto

Copy link
Copy Markdown
Contributor

Adds the ZRANGESTORE command to node.js client.

@acarbonetto acarbonetto added the node 🐢 Node.js wrapper label Aug 1, 2024
@acarbonetto acarbonetto self-assigned this Aug 1, 2024
@acarbonetto
acarbonetto requested a review from a team as a code owner August 1, 2024 07:07
Comment thread node/src/BaseClient.ts Outdated
Comment thread node/src/BaseClient.ts
Comment thread node/src/Transaction.ts Outdated
Comment thread node/src/BaseClient.ts
Comment thread node/src/BaseClient.ts Outdated
Comment thread node/src/BaseClient.ts Outdated
Comment thread node/src/BaseClient.ts Outdated
Comment thread node/src/Transaction.ts Outdated
Comment thread node/src/Transaction.ts Outdated
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
acarbonetto force-pushed the node/integ_acarbo_zrangestore branch from 533af1b to 95e5a0d Compare August 7, 2024 22:47
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Comment thread node/tests/GlideClusterClient.test.ts Outdated
Comment thread node/tests/TestUtilities.ts Outdated
Comment thread node/tests/SharedTests.ts
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Comment thread node/tests/SharedTests.ts
Comment thread node/src/BaseClient.ts
* const result = await client.zrangeStore("destination_key", "my_sorted_set", { start: 0, stop: -1 });
* console.log(result); // Output: 7 - "destination_key" contains a sorted set with the 7 members from "my_sorted_set".
* ```
* @example

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we create a single @example or two?

@yipin-chen yipin-chen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add version check for all tests.
If possible, please also add comments to the tests to help reader understand each step.

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
acarbonetto merged commit c101a6d into valkey-io:main Aug 9, 2024
@acarbonetto
acarbonetto deleted the node/integ_acarbo_zrangestore branch August 9, 2024 16:50
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Aug 12, 2024
* Node: Add ZRANGESTORE command

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Yury-Fridlyand pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 6, 2025
* Node: Add ZRANGESTORE command

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
* Node: Add ZRANGESTORE command

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

node 🐢 Node.js wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants