Node: add BZMPOP command - #2018
Merged
Yury-Fridlyand merged 7 commits intoJul 26, 2024
Merged
Conversation
yipin-chen
reviewed
Jul 25, 2024
yipin-chen
reviewed
Jul 25, 2024
yipin-chen
reviewed
Jul 25, 2024
yipin-chen
reviewed
Jul 25, 2024
| modifier, | ||
| ]; | ||
|
|
||
| if (count !== undefined) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (count !== undefined) { | |
| if (count) { |
Contributor
Author
There was a problem hiding this comment.
We can do that with non-number types however, we can't do that with number types because it can be 0 which would be treated as false and behaves differently.
yipin-chen
approved these changes
Jul 25, 2024
yipin-chen
left a comment
yipin-chen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - with few minor comments
aaron-congo
reviewed
Jul 25, 2024
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
GumpacG
force-pushed
the
node/integ_guiang_bzmpop_valkey-37
branch
from
July 25, 2024 22:48
6085cd8 to
b41712a
Compare
aaron-congo
approved these changes
Jul 25, 2024
Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com> Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Yury-Fridlyand
approved these changes
Jul 25, 2024
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://valkey.io/commands/bzmpop/