Node: add LMOVE - #2002
Merged
Yury-Fridlyand merged 46 commits intoJul 25, 2024
Merged
Node: add LMOVE#2002
Conversation
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
cyip10
changed the title
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
GumpacG
reviewed
Jul 24, 2024
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <168601573+cyip10@users.noreply.github.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
…movefinal' into node/integ_cyip10_lmovefinal
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Yury-Fridlyand
left a comment
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
Please add version check to the test
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Yury-Fridlyand
approved these changes
Jul 24, 2024
yipin-chen
approved these changes
Jul 24, 2024
yipin-chen
left a comment
yipin-chen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - don't forget to add version check in SharedTests.
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
GumpacG
approved these changes
Jul 24, 2024
GumpacG
left a comment
GumpacG
left a comment
Contributor
There was a problem hiding this comment.
SharedTest still needs version checks but looks good otherwise.
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
acarbonetto
reviewed
Jul 24, 2024
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
shohamazon
reviewed
Jul 25, 2024
shohamazon
reviewed
Jul 25, 2024
| * | ||
| * since Valkey version 6.2.0. | ||
| */ | ||
| public lmove( |
Collaborator
There was a problem hiding this comment.
Suggested change
| public lmove( | |
| public async lmove( |
There was a problem hiding this comment.
It is not async in transaction I think
Contributor
There was a problem hiding this comment.
async on the exec() call!
shohamazon
reviewed
Jul 25, 2024
| * @param source - The key to the source list. | ||
| * @param destination - The key to the destination list. | ||
| * @param whereFrom - The {@link ListDirection} to remove the element from. | ||
| * @param whereTo - The {@link ListDirection} to add the element to. |
Collaborator
There was a problem hiding this comment.
I dont remember what we said, does @link works? or is it a temporary template until we decide what we should do?
There was a problem hiding this comment.
It should, according to docs: https://tsdoc.org/pages/tags/link/
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
cyip10
force-pushed
the
node/integ_cyip10_lmovefinal
branch
from
July 25, 2024 19:04
d3eabef to
3e5c94d
Compare
Yury-Fridlyand
approved these changes
Jul 25, 2024
Signed-off-by: Chloe Yip <168601573+cyip10@users.noreply.github.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
affonsov
pushed a commit
that referenced
this pull request
Aug 21, 2026
* implement lmove Signed-off-by: Chloe Yip <chloe.yip@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.