Python: add XCLAIM command - #1772
Conversation
acarbonetto
left a comment
acarbonetto
left a comment
There was a problem hiding this comment.
looks good. just a couple of nit comments from me
| await self._execute_command(RequestType.XClaim, args), | ||
| ) | ||
|
|
||
| async def xclaim_just_id( |
There was a problem hiding this comment.
| async def xclaim_just_id( | |
| async def xclaim_justid( |
There was a problem hiding this comment.
just because the argument is called justid on Valkey
There was a problem hiding this comment.
We already have async def xautoclaim_just_id, should rename as well @acarbonetto ?
There was a problem hiding this comment.
I was about to say the same, that this was aligning with xautoclaim_just_id. Please suggest if we want to rename both.
|
|
||
| return self.append_command(RequestType.XClaim, args) | ||
|
|
||
| def xclaim_just_id( |
There was a problem hiding this comment.
| def xclaim_just_id( | |
| def xclaim_justid( |
| TIME_REDIS_API = "TIME" | ||
| RETRY_COUNT_REDIS_API = "RETRYCOUNT" | ||
| FORCE_REDIS_API = "FORCE" | ||
| JUST_ID_REDIS_API = "JUSTID" |
There was a problem hiding this comment.
nit
| JUST_ID_REDIS_API = "JUSTID" | |
| JUSTID_REDIS_API = "JUSTID" |
There was a problem hiding this comment.
Please double confirm as it is a straight copy from java/client/src/main/java/glide/api/models/commands/stream/StreamClaimOptions.java#L31
There was a problem hiding this comment.
Sorry... I missed it before. Again, not worthwhile probably.
| await self._execute_command(RequestType.XClaim, args), | ||
| ) | ||
|
|
||
| async def xclaim_just_id( |
There was a problem hiding this comment.
We already have async def xautoclaim_just_id, should rename as well @acarbonetto ?
| idle (Optional[int]): Set the idle time (last time it was delivered) of the message in milliseconds. If idle | ||
| is not specified, an idle of 0 is assumed, that is, the time count is reset because the message now has a | ||
| new owner trying to process it. | ||
| idle_unix_time (Optional[str]): This is the same as idle but instead of a relative amount of milliseconds, |
There was a problem hiding this comment.
| idle_unix_time (Optional[str]): This is the same as idle but instead of a relative amount of milliseconds, | |
| idle_unix_time (Optional[int]): This is the same as idle but instead of a relative amount of milliseconds, |
There was a problem hiding this comment.
Yury, which hardware store did you get your laser eyes from, I need name, address and aisle number, please 🙏
Yury-Fridlyand
left a comment
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
OK for me, regardless of function renamed or not
* Python: add XCLAIM command * add CHANGELOG * address comments
* Python: add XCLAIM command * add CHANGELOG * address comments
* Python: add XCLAIM command * add CHANGELOG * address comments
3 participants
Issue #, if available:
N/A
Description of changes:
Python: add XCLAIM command
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.