Python: add XINFO GROUPS and XINFO CONSUMERS commands - #1753
Merged
acarbonetto merged 5 commits intoJul 2, 2024
Merged
Conversation
aaron-congo
force-pushed
the
python/integ_acongo_xinfo_groups
branch
from
July 2, 2024 16:45
485c8cc to
7fcea9f
Compare
acarbonetto
reviewed
Jul 2, 2024
GumpacG
reviewed
Jul 2, 2024
| assert consumer1_info.get(b"name") == consumer1.encode() | ||
| assert consumer1_info.get(b"pending") == 1 | ||
| assert cast(int, consumer1_info.get(b"idle")) > 0 | ||
| if not await check_if_server_version_lt(redis_client, "7.2.0"): |
Contributor
There was a problem hiding this comment.
Should we test that idle has different meanings before and after 7.2.0? From docs:
Note that before Redis 7.2.0, idle used to denote the time passed since last successful interaction. In 7.2.0, inactive was added and idle was changed to denote the time passed since last attempted interaction.
Contributor
Author
There was a problem hiding this comment.
Personally I don't think its necessary, but if someone else disagrees let me know. I think we've tested the API functionality well and adding that extra test would be testing Redis functionality more than the API (although I admit the line between the two can be hazy sometimes)
GumpacG
approved these changes
Jul 2, 2024
aaron-congo
force-pushed
the
python/integ_acongo_xinfo_groups
branch
from
July 2, 2024 18:29
5657d23 to
034aaf0
Compare
acarbonetto
approved these changes
Jul 2, 2024
acarbonetto
left a comment
acarbonetto
left a comment
Contributor
There was a problem hiding this comment.
LGTM - just some minor cleanup maybe
| transaction.xtrim(key11, TrimByMinId(threshold="0-2", exact=True)) | ||
| args.append(1) | ||
| transaction.xinfo_groups(key11) | ||
| args.append([]) |
acarbonetto
approved these changes
Jul 2, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jul 16, 2024
* Python: add XINFO GROUPS and XINFO CONSUMERS commands * Update CHANGELOG * Update types to use TEncodable and bytes * PR suggestions * PR suggestions
Yury-Fridlyand
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 6, 2025
* Python: add XINFO GROUPS and XINFO CONSUMERS commands * Update CHANGELOG * Update types to use TEncodable and bytes * PR suggestions * PR suggestions
affonsov
pushed a commit
that referenced
this pull request
Aug 21, 2026
* Python: add XINFO GROUPS and XINFO CONSUMERS commands * Update CHANGELOG * Update types to use TEncodable and bytes * PR suggestions * PR suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/xinfo-groups/
https://redis.io/docs/latest/commands/xinfo-consumers/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.