Skip to content

Python: add WATCH and UNWATCH commands - #1736

Merged
acarbonetto merged 14 commits into
valkey-io:mainfrom
Bit-Quill:python/dev_jamesx_watch
Jul 1, 2024
Merged

Python: add WATCH and UNWATCH commands#1736
acarbonetto merged 14 commits into
valkey-io:mainfrom
Bit-Quill:python/dev_jamesx_watch

Conversation

@jamesx-improving

@jamesx-improving jamesx-improving commented Jun 30, 2024

Copy link
Copy Markdown
Collaborator

Issue #, if available:
N/A

Description of changes:
Add WATCH and UNWATCH commands

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jamesx-improving
jamesx-improving requested a review from a team as a code owner June 30, 2024 23:00
@jamesx-improving jamesx-improving added the python 🐍 Python wrapper label Jun 30, 2024
Yury-Fridlyand
Yury-Fridlyand reviewed Jun 30, 2024
View reviewed changes
Comment thread python/python/glide/async_commands/core.py
Comment thread python/python/tests/test_async_client.py
acarbonetto
acarbonetto reviewed Jun 30, 2024
View reviewed changes
Comment thread python/python/tests/test_async_client.py
GumpacG
GumpacG suggested changes Jul 1, 2024
View reviewed changes
Comment thread python/python/tests/test_async_client.py Outdated
Comment thread python/python/tests/test_async_client.py
Yury-Fridlyand
Yury-Fridlyand reviewed Jul 1, 2024
View reviewed changes

@Yury-Fridlyand Yury-Fridlyand left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry.

aaron-congo and others added 8 commits June 30, 2024 20:10
@aaron-congo @jamesx-improving
Python: added XAUTOCLAIM command (valkey-io#1718)
41fbd60 
* Python: add XAUTOCLAIM command

* minor doc update

* Minor doc update

* PR suggestions

* Update test assertions with string conversions

* PR suggestions

* Add clarifying comments
@GumpacG @Yury-Fridlyand @jamesx-improving
Python: Add ZSCAN and HSCAN commands (valkey-io#1732)
e87b6cc 
* Added zscan command

* Added HSCAN command

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Fixed tests and addressed comments

* Update python/python/tests/test_async_client.py

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@jamesx-improving
Python: add WATCH and UNWATCH commands
fa823d1
@jamesx-improving
Python: add WATCH and UNWATCH commands
ff8b96e
@jamesx-improving
Merge branch 'main' into python/dev_jamesx_watch
8932a25
@jamesx-improving
add changelog
6ea2c4d
@jamesx-improving
Merge branch 'main' into python/dev_jamesx_watch
49ad695
@jamesx-improving
fix broken syntax after solving conflicts
41be409
@acarbonetto
acarbonetto merged commit 8e048b1 into valkey-io:main Jul 1, 2024
@Yury-Fridlyand
Yury-Fridlyand deleted the python/dev_jamesx_watch branch July 1, 2024 04:46
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jul 16, 2024
@jamesx-improving @aaron-congo
@GumpacG @Yury-Fridlyand @cyip10
Python: add WATCH and UNWATCH commands (valkey-io#1736)
954b624 
* Python: add WATCH and UNWATCH commands

* isort

* update redis_client type for test_unwatch_with_route()

* add watch to the correct cluster test

* add cluster mode note

* address comments from GumpacG

* Python: added XAUTOCLAIM command (valkey-io#1718)

* Python: add XAUTOCLAIM command

* minor doc update

* Minor doc update

* PR suggestions

* Update test assertions with string conversions

* PR suggestions

* Add clarifying comments

* Python: Add ZSCAN and HSCAN commands (valkey-io#1732)

* Added zscan command

* Added HSCAN command

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Fixed tests and addressed comments

* Update python/python/tests/test_async_client.py

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Python: add WATCH and UNWATCH commands

* Python: add WATCH and UNWATCH commands

* add changelog

* fix broken syntax after solving conflicts

---------

Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand added a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 6, 2025
@jamesx-improving @aaron-congo
@GumpacG @Yury-Fridlyand @cyip10
Python: add WATCH and UNWATCH commands (valkey-io#1736)
885a9c4 
* Python: add WATCH and UNWATCH commands

* isort

* update redis_client type for test_unwatch_with_route()

* add watch to the correct cluster test

* add cluster mode note

* address comments from GumpacG

* Python: added XAUTOCLAIM command (valkey-io#1718)

* Python: add XAUTOCLAIM command

* minor doc update

* Minor doc update

* PR suggestions

* Update test assertions with string conversions

* PR suggestions

* Add clarifying comments

* Python: Add ZSCAN and HSCAN commands (valkey-io#1732)

* Added zscan command

* Added HSCAN command

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Fixed tests and addressed comments

* Update python/python/tests/test_async_client.py

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Python: add WATCH and UNWATCH commands

* Python: add WATCH and UNWATCH commands

* add changelog

* fix broken syntax after solving conflicts

---------

Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
@jamesx-improving @aaron-congo
@GumpacG @Yury-Fridlyand
Python: add WATCH and UNWATCH commands (#1736)
b967169 
* Python: add WATCH and UNWATCH commands

* isort

* update redis_client type for test_unwatch_with_route()

* add watch to the correct cluster test

* add cluster mode note

* address comments from GumpacG

* Python: added XAUTOCLAIM command (#1718)

* Python: add XAUTOCLAIM command

* minor doc update

* Minor doc update

* PR suggestions

* Update test assertions with string conversions

* PR suggestions

* Add clarifying comments

* Python: Add ZSCAN and HSCAN commands (#1732)

* Added zscan command

* Added HSCAN command

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Debug tests

* Fixed tests and addressed comments

* Update python/python/tests/test_async_client.py

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Python: add WATCH and UNWATCH commands

* Python: add WATCH and UNWATCH commands

* add changelog

* fix broken syntax after solving conflicts

---------

Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments
@GumpacG GumpacG GumpacG approved these changes
@acarbonetto acarbonetto acarbonetto approved these changes
@Elen-Ghulam Elen-Ghulam Elen-Ghulam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

python 🐍 Python wrapper

Projects

Valkey-GLIDE - internal
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jamesx-improving @GumpacG @Yury-Fridlyand @acarbonetto @Elen-Ghulam @aaron-congo