Skip to content

Python: add XGROUP CREATECONSUMER and XGROUP DELCONSUMER commands - #1658

Merged
acarbonetto merged 2 commits into
valkey-io:mainfrom
Bit-Quill:python/integ_acongo_xgroup_createconsumer_delconsumer
Jun 25, 2024
Merged

acarbonetto merged 2 commits into
valkey-io:mainfrom
Bit-Quill:python/integ_acongo_xgroup_createconsumer_delconsumer

Conversation

@aaron-congo

@aaron-congo aaron-congo commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

Issue #, if available:
N/A

Description of changes:
https://redis.io/docs/latest/commands/xgroup-createconsumer/
https://redis.io/docs/latest/commands/xgroup-delconsumer/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aaron-congo
aaron-congo requested a review from a team as a code owner June 25, 2024 19:21
Comment thread python/python/glide/async_commands/core.py Outdated
Comment thread python/python/glide/async_commands/core.py Outdated
Comment thread python/python/glide/async_commands/core.py Outdated
Comment thread python/python/glide/async_commands/core.py Outdated
Comment thread python/python/glide/async_commands/transaction.py Outdated
Comment thread python/python/glide/async_commands/transaction.py Outdated
Comment thread python/python/glide/async_commands/transaction.py Outdated
Comment thread python/python/glide/async_commands/transaction.py Outdated
== 0
)

# TODO: use XREADGROUP to mark pending messages for the consumer so that we get non-zero return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@aaron-congo aaron-congo added the python 🐍 Python wrapper label Jun 25, 2024
@acarbonetto
acarbonetto merged commit 04e15d0 into valkey-io:main Jun 25, 2024
@acarbonetto
acarbonetto deleted the python/integ_acongo_xgroup_createconsumer_delconsumer branch June 25, 2024 21:05
jduo pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 28, 2024
…lkey-io#1658)

* Python: add XGROUP CREATECONSUMER and XGROUP DELCONSUMER commands

* Rename consumer variable to consumer_name
affonsov pushed a commit that referenced this pull request Aug 21, 2026
)

* Python: add XGROUP CREATECONSUMER and XGROUP DELCONSUMER commands

* Rename consumer variable to consumer_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python 🐍 Python wrapper

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants