Skip to content

Python: add ZRANDMEMBER command - #1413

Merged
Yury-Fridlyand merged 6 commits into
valkey-io:mainfrom
Bit-Quill:python/integ_acongo_zrandmember
May 16, 2024
Merged

Python: add ZRANDMEMBER command#1413
Yury-Fridlyand merged 6 commits into
valkey-io:mainfrom
Bit-Quill:python/integ_acongo_zrandmember

Conversation

@aaron-congo

@aaron-congo aaron-congo commented May 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue #, if available:
https://redis.io/docs/latest/commands/zrandmember/

Description of changes:

  • adds ZRANDMEMBER command to the Python client
  • adds value conversion to convert RESP2 responses (flat arrays with scores as strings) to RESP2 responses (array of pairs with scores as doubles)
    • refactors some logic that was previously used to convert to ArrayOfKeyValuePairs, since the logic to convert to ArrayOfMemberScorePairs is the same but has an added step of converting scores to type double

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aaron-congo
aaron-congo requested a review from a team as a code owner May 14, 2024 22:02
@aaron-congo aaron-congo added the python 🐍 Python wrapper label May 14, 2024
@aaron-congo
aaron-congo requested review from Yury-Fridlyand, acarbonetto, jonathanl-bq and shohamazon and removed request for Yury-Fridlyand May 14, 2024 22:06
shohamazon
shohamazon approved these changes May 16, 2024
View reviewed changes

@shohamazon shohamazon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many sorted set commands

Comment thread python/python/glide/async_commands/core.py Outdated
Comment thread python/python/glide/async_commands/core.py Outdated
Comment thread python/python/glide/async_commands/core.py Outdated
Comment thread python/python/glide/async_commands/core.py Outdated
Comment thread python/python/glide/async_commands/transaction.py
Comment thread python/python/tests/test_async_client.py Outdated
Comment thread python/python/tests/test_async_client.py Outdated
@aaron-congo
aaron-congo force-pushed the python/integ_acongo_zrandmember branch from c6ac0d2 to 74f12ce Compare May 16, 2024 18:30
@Yury-Fridlyand
Yury-Fridlyand merged commit 5b2e925 into valkey-io:main May 16, 2024
@Yury-Fridlyand
Yury-Fridlyand deleted the python/integ_acongo_zrandmember branch May 16, 2024 23:32
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
@aaron-congo @cyip10
Python: add ZRANDMEMBER command (valkey-io#1413)
ac66c47 
* Python: add ZRANDMEMBER command (#276)
affonsov pushed a commit that referenced this pull request Aug 21, 2026
@aaron-congo
Python: add ZRANDMEMBER command (#1413)
73ec37f 
* Python: add ZRANDMEMBER command (#276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shohamazon shohamazon shohamazon approved these changes
@acarbonetto acarbonetto Awaiting requested review from acarbonetto
@jonathanl-bq jonathanl-bq Awaiting requested review from jonathanl-bq
+1 more reviewer
@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

python 🐍 Python wrapper

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aaron-congo @Yury-Fridlyand @shohamazon