Skip to content

Python: Fix typing #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barshaul merged 1 commit into from
Apr 2, 2024
+5 −2
Merged

Python: Fix typing #1203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
#### Changes
* Python: Added JSON.DEL JSON.FORGET commands ([#1146](https://github.com/aws/glide-for-redis/pull/1146))

#### Fixes
* Python: Fix typing error "‘type’ object is not subscriptable" ([#1203](https://github.com/aws/glide-for-redis/pull/1203))

## 0.3.1 (2024-03-28)

#### Fixes
Expand Down
4 changes: 2 additions & 2 deletions python/python/glide/redis_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import asyncio
import threading
from typing import List, Optional, Tuple, Union, cast
from typing import List, Optional, Tuple, Type, Union, cast

import async_timeout
from glide.async_commands.cluster_commands import ClusterCommands
Expand Down Expand Up @@ -35,7 +35,7 @@

def get_request_error_class(
error_type: Optional[RequestErrorType.ValueType],
) -> type[RequestError]:
) -> Type[RequestError]:
if error_type == RequestErrorType.Disconnect:
return ConnectionError
if error_type == RequestErrorType.ExecAbort:
Expand Down