Node: added zrange and zrangeWithScores commands. - #1115
Merged
Merged
Conversation
adanWattad
force-pushed
the
node/zrange
branch
2 times, most recently
from
March 13, 2024 15:21
47e00a5 to
71af8de
Compare
barshaul
reviewed
Mar 19, 2024
barshaul
requested changes
Mar 19, 2024
barshaul
left a comment
barshaul
left a comment
Collaborator
There was a problem hiding this comment.
Why RangeByScoreOrLex isn't separated to two types as we do in python, RangeByScore and RangeByLex? we shouldn't accept ScoreLimit as strings when is lex is false, and we should except number when is lex is true. We also cannot use it later on with the specific zrange functions (e.g. ZRANGEBYLEX). Please follow python's design, and ping me when it's ready for review 🙏
barshaul
reviewed
Mar 21, 2024
barshaul
reviewed
Mar 21, 2024
barshaul
reviewed
Mar 21, 2024
barshaul
reviewed
Mar 21, 2024
barshaul
reviewed
Mar 21, 2024
| */ | ||
| type Range<T> = { | ||
| /** | ||
| * The start score boundary. |
Collaborator
There was a problem hiding this comment.
same - it should be used both for lex and score, so the doc might be confusing
barshaul
reviewed
Mar 21, 2024
barshaul
reviewed
Mar 21, 2024
| }; | ||
| }; | ||
|
|
||
| export type RangeByScore = Range<number> & { type: "byScore" }; |
Collaborator
There was a problem hiding this comment.
I think "Lex" and "Score" is sufficient for 'type'
Contributor
Author
|
@barshaul ready |
barshaul
reviewed
Apr 2, 2024
| * If `key` does not exist, it is treated as an empty sorted set, and the command returns an empty array. | ||
| * | ||
| * @example | ||
| * await client.zadd("mySortedSet", \{ member1: 1.0, member2: 2.0, member3: 3.0 \}); |
Collaborator
There was a problem hiding this comment.
Please follow format for examples:
* @example
* ```typescript
* // Example usage of the echo method
* const echoedMessage = await client.echo("Glide-for-Redis");
* console.log(echoedMessage); // Output: "Glide-for-Redis"
* ```
*/
barshaul
reviewed
Apr 2, 2024
| * @example | ||
| * await client.zadd("mySortedSet", \{ member1: 1.0, member2: 2.0, member3: 3.0 \}); | ||
| * | ||
| * await client.zrange("mySortedSet", \{ start: 0, stop: -1 \}); |
barshaul
reviewed
Apr 2, 2024
| export type RangeByScore = SortedSetRange<number> & { type: "byScore" }; | ||
| export type RangeByLex = SortedSetRange<string> & { type: "byLex" }; | ||
|
|
||
| function getScoreLimitArg( |
barshaul
reviewed
Apr 2, 2024
|
|
||
| function getScoreLimitArg( | ||
| score: ScoreBoundary<number> | ScoreBoundary<string>, | ||
| isLex: boolean = false, |
Collaborator
There was a problem hiding this comment.
please add documentation, this function isn't trivial
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
--------- Co-authored-by: Adan <adanwat@amazon.com> Co-authored-by: Shoham Elias <shohame@amazon.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
affonsov
pushed a commit
that referenced
this pull request
Aug 21, 2026
--------- Co-authored-by: Adan <adanwat@amazon.com> Co-authored-by: Shoham Elias <shohame@amazon.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.