Make search case-insensitive in Send Command view - #426
Merged
ravjotbrar merged 1 commit intoJul 29, 2026
Merged
ravjotbrar merged 1 commit into
ravjotbrar merged 1 commit into
Conversation
Signed-off-by: antonin-suzor <antonin@suzor.net>
ravjotbrar
approved these changes
Jul 29, 2026
ravjotbrar
left a comment
ravjotbrar
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR @antonin-suzor. LGTM!
Contributor
Author
|
Thank you for the review ! I don't have merge permission, so you will have to merge it yourself @ravjotbrar |
ravjotbrar
pushed a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: antonin-suzor <antonin@suzor.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #424
This PR makes search case-insensitive in the Send Command view.
Affected search bars are:
This works by lowercasing the filter (once per change/render) and lowercasing the entries (once per entry).
Known limitation
Text highlighting in diff view is still case-sensitive in
CommandElements.tsx/KeyFilterable.I did not find a straight-forward way to implement it, and did not know if it was included in the scope of the issue.
A possible implementation (not explored) would be to manually split the "normal-case" keyPathString based on split results of the lowercase filter against a lowercased keyPathString. If it should be included in the PR, I can look to add it.
Tests ran
npm run build:frontendnpm run lintChange Visualization
Before the changes:
https://github.com/user-attachments/assets/855c386f-39e1-4ecc-91c9-7d56e7698cac
After the changes:
https://github.com/user-attachments/assets/8873c25f-8f08-4230-be43-168140f2f907