Fix cluster state on WebSocket reconnect with shared backend - #298
Merged
Merged
Conversation
…eletion Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
Signed-off-by: Ravjot Brar <ravjot.brar@improving.com>
arseny-kostenko
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When multiple users share the same backend, a reconnecting user would receive updateClusterInfo instead of addCluster because the global clients map still held the existing GlideClusterClient. Since updateClusterInfo is a no-op on an empty frontend state, the cluster topology would never populate after reconnect.
In addition, clusterNodesRegistry was not cleaned up properly, this fix addresses that.
Changes:
returnExistingClusterClient now sends addCluster instead of updateClusterInfo, so a reconnecting client always rebuilds its cluster state from scratch
teardownConnection now accepts an optional clusterNodesRegistry and deletes the cluster entry when the last client for that cluster is closed — preventing stale entries
from causing fan-out to disconnected nodes. This cleanup is skipped when USE_CLUSTER_ORCHESTRATOR=true since the registry is managed by the reconcile loop in that mode
closeConnection and the WebSocket close handler both pass clusterNodesRegistry to teardownConnection
Change Visualization
Include a screenshot/video of before and after the change.