Skip to content

fix monitorEnabled for getHotKeysEpic - #263

Merged
ArgusLi merged 3 commits into
mainfrom
fix/monitor-wording
Apr 8, 2026
Merged

ArgusLi merged 3 commits into
mainfrom
fix/monitor-wording

Conversation

@ArgusLi

@ArgusLi ArgusLi commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Description

This PR changes 3 things with monitor with relation to hotKeys:

  • Hot Keys checks if monitor is enabled as a fallback to get the hot keys. However, it accesses a value that doesn't exist. This fix replaces that with the exported function selectMonitorRunning().
  • Previously useMonitor (used by hotKeys) starts and stops the monitor. Monitor's lifecycle should be controlled purely by the monitor endpoint. This fix changes useMonitor to purely return monitor data.
  • willCompleteAt within the monitor response was not being updated based on cycles. i.e. it was set in the first run to be Date.now() + monitoring duration, then never updated again. This fix updates willCompleteAt for each cycle.

Signed-off-by: Argus Li <contactme@chunkeili.com>
@ArgusLi
ArgusLi requested a review from ravjotbrar April 6, 2026 23:48
ArgusLi added 2 commits April 7, 2026 08:50
Previously useMonitor starts then stops the monitor. useMonitor is not used by the Monitor endpoint. Monitor should not be controlled by any other endpoint. Therefore modifying useMonitor to just read data makes sense.

Signed-off-by: Argus Li <contactme@chunkeili.com>
Signed-off-by: Argus Li <contactme@chunkeili.com>
@ArgusLi
ArgusLi requested a review from arseny-kostenko April 7, 2026 15:54
@ArgusLi
ArgusLi merged commit bfdaecc into main Apr 8, 2026
7 checks passed
@ArgusLi
ArgusLi deleted the fix/monitor-wording branch April 8, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants