Skip to content

uucore: tr, nice -n . 2>/dev/full does not abort - #10762

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:nice-abort
Mar 9, 2026
Merged

uucore: tr, nice -n . 2>/dev/full does not abort#10762
sylvestre merged 1 commit into
uutils:mainfrom
oech3:nice-abort

Conversation

@oech3

@oech3 oech3 commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Closes #10747 . Removes Try --help message which matches with gnu 9.10.
[Edit] Closes #10621

@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@oech3
oech3 marked this pull request as ready for review February 6, 2026 05:53
@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

Comment thread src/uu/nice/src/nice.rs Outdated
Comment thread src/uu/nice/src/nice.rs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cleanup this too.

@github-actions

github-actions Bot commented Feb 7, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@oech3
oech3 force-pushed the nice-abort branch 2 times, most recently from 7d222d9 to 3b4e61b Compare February 8, 2026 15:55
@oech3

This comment was marked as resolved.

@codspeed-hq

codspeed-hq Bot commented Feb 8, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.92%

⚡ 1 improved benchmark
✅ 303 untouched benchmarks
⏩ 42 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation expand_many_lines[100000] 64.6 ms 62.2 ms +3.92%

Comparing oech3:nice-abort (da69941) with main (9654e4a)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Feb 8, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)

@oech3

This comment was marked as resolved.

@oech3

This comment was marked as outdated.

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

@oech3 oech3 changed the title nice -n . 2>/dev/full does not abort uucore: tr, nice -n . 2>/dev/full does not abort Mar 7, 2026
@oech3

This comment was marked as resolved.

@sylvestre
sylvestre merged commit bf955a9 into uutils:main Mar 9, 2026
162 of 163 checks passed
@oech3
oech3 deleted the nice-abort branch March 9, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nice -n . 2>/dev/full SIGABRT tr 2>/dev/full SIGABRT (using UUsageError)

3 participants