Skip to content

Optional btn & input font family - #28068

Merged
XhmikosR merged 2 commits into
v4-devfrom
v4-dev-mc-optinal-input-btn-font-family
Feb 7, 2019
Merged

Optional btn & input font family#28068
XhmikosR merged 2 commits into
v4-devfrom
v4-dev-mc-optinal-input-btn-font-family

Conversation

@MartijnCuppens

Copy link
Copy Markdown
Member

Optional font family for .btns and .form-controls. Doesn't generate any css by default.

@mdo

mdo commented Jan 20, 2019

Copy link
Copy Markdown
Member

We'll want to check the default font stacks for some older browsers. I can't remember for certain anymore, but I feel like some weren't inheriting their fonts in inputs and buttons.

@MartijnCuppens

Copy link
Copy Markdown
Member Author

@mdo, I guess this is already fixed in reboot:

bootstrap/scss/_reboot.scss

Lines 313 to 322 in e65dccf

input,
button,
select,
optgroup,
textarea {
margin: 0; // Remove the margin in Firefox and Safari
font-family: inherit;
font-size: inherit;
line-height: inherit;
}

@mdo mdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well then, awesome! :shipit: 😆

@mdo mdo mentioned this pull request Feb 7, 2019
@XhmikosR
XhmikosR merged commit 8b41cb1 into v4-dev Feb 7, 2019
@XhmikosR
XhmikosR deleted the v4-dev-mc-optinal-input-btn-font-family branch February 7, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants