Skip to content

Added simple descriptions to files missing descriptions #9

Merged
trekhleb merged 3 commits into
trekhleb:masterfrom
scraggard:master
Oct 5, 2018
Merged

Added simple descriptions to files missing descriptions #9
trekhleb merged 3 commits into
trekhleb:masterfrom
scraggard:master

Conversation

@scraggard

Copy link
Copy Markdown
Contributor

Added simple descriptions/summary to the top of the files that did not have any descriptions/summary for:

  1. test_class_objects.py
  2. test_inheritance.py
  3. test_method_objects.py
  4. test_multiple_inheritance.py
  5. test_file_methdos.py
  6. test_file_reading.py
  7. test_math.py

scraggard and others added 2 commits October 4, 2018 16:26
… the files.

Added simple descriptions/summary for test_class_objects.py, test_inheritance.py, test_method_objects.py, test_multiple_inheritance.py, test_file_methdos.py, test_file_reading.py, test_math.py
@trekhleb

trekhleb commented Oct 5, 2018

Copy link
Copy Markdown
Owner

@scraggard thank you for additional comments!
Could you please address the pylint and flake issues that make PR checks fail?

@scraggard

Copy link
Copy Markdown
Contributor Author

Hi, I apologize about the trailing spaces that were giving an issue! It looks like it has cleared now.

Just a heads-up, it's a very minor thing but test_files_methdos.py looks like a typo for test_files_methods.py!

Thank you for letting me be a part of this! I believe that this is very useful for people learning python by giving them hands-on code.

@trekhleb

trekhleb commented Oct 5, 2018

Copy link
Copy Markdown
Owner

@scraggard thanks for the good comments in code once again!
And also thank you for the pointing out to the typo in test_files_methdos.py filename. I'll change that just right after I merge your PR.

@trekhleb trekhleb merged commit 96590be into trekhleb:master Oct 5, 2018
@trekhleb

trekhleb commented Oct 5, 2018

Copy link
Copy Markdown
Owner

@scraggard the filename is fixed now as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants