fix(configuration): correct TLS naming in v3 schema - #2005
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects TLS terminology in the v3.0.0 configuration schema and standardizes the schema-neutral Axum TLS helper module naming (tsl → tls), while explicitly preserving the v2 compatibility contract (TslConfig / tsl_config) until the final consumer migration in #1980.
Changes:
- Introduces
v3_0_0::tls::TlsConfigand renames v3 DTO fields fromtsl_configtotls_config(with unit tests proving TOML deserialization). - Renames the Axum helper module path
torrust_tracker_axum_server::tsl→...::tlsand updates imports across bootstrap and server packages. - Updates v3 docs and relevant open issue specs to reflect the corrected TLS naming and the intentional v2/v3 boundary.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/bootstrap/jobs/tracker_apis.rs | Update Axum TLS helper import path to tls. |
| src/bootstrap/jobs/http_tracker.rs | Update Axum TLS helper import path to tls. |
| packages/configuration/src/v3_0_0/tracker_api.rs | Rename v3 HTTP API TLS field to tls_config and add deserialization test. |
| packages/configuration/src/v3_0_0/tls.rs | Add new v3-owned TlsConfig DTO. |
| packages/configuration/src/v3_0_0/mod.rs | Fix v3 docs from “TSL” to “TLS” and export tls module. |
| packages/configuration/src/v3_0_0/http_tracker.rs | Rename v3 HTTP tracker TLS field to tls_config and add deserialization test. |
| packages/axum-server/src/tls.rs | Rename local parameter identifiers to tls_* while retaining TslConfig type boundary. |
| packages/axum-server/src/lib.rs | Switch module export from tsl to tls. |
| packages/axum-server/README.md | Update docs to refer to tls.rs. |
| packages/axum-rest-api-server/src/testing/environment.rs | Update Axum TLS helper import path + comment wording. |
| packages/axum-rest-api-server/src/server.rs | Update Axum TLS helper import path + comment wording. |
| packages/axum-http-server/src/testing/environment.rs | Update Axum TLS helper import path. |
| packages/axum-http-server/src/server.rs | Update Axum TLS helper import path + comment wording. |
| docs/issues/open/1981-1978-fix-tsl-config-tls-config-typo.md | Record the compatibility boundary and mark the subissue as completed. |
| docs/issues/open/1979-1978-copy-configuration-schema-v2-to-v3-baseline.md | Mark the baseline-copy subissue as completed and update progress metadata. |
| docs/issues/open/1978-configuration-overhaul-epic.md | Update EPIC subissue table to reflect #1979/#1981 completion. |
| docs/issues/open/1640-1978-per-http-tracker-on-reverse-proxy-setting.md | Update forward-looking v3 docs to use tls_config terminology. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
ACK 3d6e95f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct TLS terminology in the v3 configuration schema and schema-neutral Axum helper module while preserving the v2 configuration contract until final migration.
v3_0_0::tls::TlsConfigand rename v3 DTO fields totls_configaxum-server::tsltoaxum-server::tlsand update direct importsTslConfigandtsl_confignames until Configuration overhaul final cleanup: remove global re-exports, migrate consumers to explicit versioned imports #1980 migrates consumers atomicallyVerification
linter allcargo test --workspaceCloses #1981
Part of #1978