Skip to content

fix(configuration): correct TLS naming in v3 schema - #2005

Merged
josecelano merged 3 commits into
torrust:developfrom
josecelano:1981-fix-tsl-config-typo
Jul 20, 2026
Merged

fix(configuration): correct TLS naming in v3 schema#2005
josecelano merged 3 commits into
torrust:developfrom
josecelano:1981-fix-tsl-config-typo

Conversation

@josecelano

Copy link
Copy Markdown
Member

Summary

Correct TLS terminology in the v3 configuration schema and schema-neutral Axum helper module while preserving the v2 configuration contract until final migration.

Verification

  • linter all
  • cargo test --workspace
  • nightly format, workspace check, and documentation build via pre-push
  • full stable test suite via pre-push

Closes #1981
Part of #1978

Copilot AI review requested due to automatic review settings July 20, 2026 16:00
@josecelano josecelano self-assigned this Jul 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects TLS terminology in the v3.0.0 configuration schema and standardizes the schema-neutral Axum TLS helper module naming (tsltls), while explicitly preserving the v2 compatibility contract (TslConfig / tsl_config) until the final consumer migration in #1980.

Changes:

  • Introduces v3_0_0::tls::TlsConfig and renames v3 DTO fields from tsl_config to tls_config (with unit tests proving TOML deserialization).
  • Renames the Axum helper module path torrust_tracker_axum_server::tsl...::tls and updates imports across bootstrap and server packages.
  • Updates v3 docs and relevant open issue specs to reflect the corrected TLS naming and the intentional v2/v3 boundary.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/bootstrap/jobs/tracker_apis.rs Update Axum TLS helper import path to tls.
src/bootstrap/jobs/http_tracker.rs Update Axum TLS helper import path to tls.
packages/configuration/src/v3_0_0/tracker_api.rs Rename v3 HTTP API TLS field to tls_config and add deserialization test.
packages/configuration/src/v3_0_0/tls.rs Add new v3-owned TlsConfig DTO.
packages/configuration/src/v3_0_0/mod.rs Fix v3 docs from “TSL” to “TLS” and export tls module.
packages/configuration/src/v3_0_0/http_tracker.rs Rename v3 HTTP tracker TLS field to tls_config and add deserialization test.
packages/axum-server/src/tls.rs Rename local parameter identifiers to tls_* while retaining TslConfig type boundary.
packages/axum-server/src/lib.rs Switch module export from tsl to tls.
packages/axum-server/README.md Update docs to refer to tls.rs.
packages/axum-rest-api-server/src/testing/environment.rs Update Axum TLS helper import path + comment wording.
packages/axum-rest-api-server/src/server.rs Update Axum TLS helper import path + comment wording.
packages/axum-http-server/src/testing/environment.rs Update Axum TLS helper import path.
packages/axum-http-server/src/server.rs Update Axum TLS helper import path + comment wording.
docs/issues/open/1981-1978-fix-tsl-config-tls-config-typo.md Record the compatibility boundary and mark the subissue as completed.
docs/issues/open/1979-1978-copy-configuration-schema-v2-to-v3-baseline.md Mark the baseline-copy subissue as completed and update progress metadata.
docs/issues/open/1978-configuration-overhaul-epic.md Update EPIC subissue table to reflect #1979/#1981 completion.
docs/issues/open/1640-1978-per-http-tracker-on-reverse-proxy-setting.md Update forward-looking v3 docs to use tls_config terminology.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/configuration/src/v3_0_0/tracker_api.rs Outdated
@josecelano

Copy link
Copy Markdown
Member Author

ACK 3d6e95f

@josecelano
josecelano merged commit bd8d4e7 into torrust:develop Jul 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix tsl_configtls_config typo across the codebase

2 participants