Skip to content

agents: Add more robust response handling to executor.go - #1316

Merged
tmc merged 2 commits into
tmc:mainfrom
xiazemin:main
Jun 28, 2025
Merged

tmc merged 2 commits into
tmc:mainfrom
xiazemin:main

Conversation

@xiazemin

Copy link
Copy Markdown
Contributor

fix a bug that cause params error

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@xiazemin

Copy link
Copy Markdown
Contributor Author

fix the error
unmarshal input: invalid character 'O' after top-level value
exit status 1

fix a bug that cause params error
@tmc tmc changed the title Update executor.go agents: Add more robust response handling to executor.go Jun 28, 2025
Add test coverage to ensure the executor properly trims nObservation:
suffix from tool inputs before passing them to tools. This prevents
tools from receiving malformed input that includes the observation
marker.

- Add TestExecutorTrimsObservationSuffix to verify trimming behavior
- Add test case in MRKL output parser for action inputs with observation suffix
- Add tools field to testAgent to support tool testing
@tmc
tmc merged commit c2f9ad7 into tmc:main Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants