Seal Parsable trait methods#797
Closed
Powerbyte7 wants to merge 2 commits into
Closed
Conversation
brianmay
approved these changes
Jul 1, 2026
Member
|
Thanks for the quick PR! I actually ended up going a bit farther, using a similar approach for the formatting trait as well. I'm not sure if it was technically necessary, but there's no harm in adding a ZST as a parameter. Given the larger scope and timeliness of the issue, I'm doing this myself. Sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents the issue in #793 from reoccurring in the future, by embedding an unnameable type in the trait method signatures. The logic is analogous to what can be seen in the following code:
For more info on this practice, see the following:
https://rust-lang.github.io/api-guidelines/future-proofing.html#newtypes-encapsulate-implementation-details-c-newtype-hide
https://predr.ag/blog/definitive-guide-to-sealed-traits-in-rust/
I have tested this PR by running
cargo test --all-features, and also also by checking that the build fails when importing the unnameable type. This PR can be considered breaking in the same way the changes to #793 were, but will improve future API stability.