perf: cache attribute factory results on TestMetadata - #4679
Merged
Conversation
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 08:33 — with
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 08:33 — with
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 08:33 — with
GitHub Actions
Failure
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a clean performance optimization that adds lazy caching for test attributes. The implementation correctly uses the null-coalescing assignment operator ( |
thomhurst
enabled auto-merge (squash)
February 6, 2026 08:49
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 09:18 — with
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 09:18 — with
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 09:18 — with
GitHub Actions
Failure
thomhurst
force-pushed
the
perf/cache-attribute-factory
branch
from
February 6, 2026 09:39
dd40c18 to
3894acb
Compare
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 09:39 — with
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 09:39 — with
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 09:39 — with
GitHub Actions
Failure
Add GetOrCreateAttributes() that lazily caches the attribute array on first call. AttributeFactory was being invoked multiple times per test during building — now it runs once and subsequent calls return the cached array, avoiding redundant attribute instantiation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thomhurst
force-pushed
the
perf/cache-attribute-factory
branch
from
February 6, 2026 10:43
3894acb to
fa06a50
Compare
thomhurst
had a problem deploying
to
Pull Requests
February 6, 2026 10:43 — with
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
February 6, 2026 10:43 — with
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
February 6, 2026 10:43 — with
GitHub Actions
Inactive
This was referenced Feb 6, 2026
This was referenced Mar 9, 2026
This was referenced Mar 16, 2026
This was referenced Mar 25, 2026
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code