Fix: Correct login_form_middle filter parameter type - #2954
Open
shsajalchowdhury wants to merge 1 commit into
Open
Fix: Correct login_form_middle filter parameter type#2954shsajalchowdhury wants to merge 1 commit into
shsajalchowdhury wants to merge 1 commit into
Conversation
The apply_filters('login_form_middle') call was passing an empty
string as the second argument instead of an array, causing fatal
errors when third-party plugins (e.g., hCaptcha) type-hint the
parameter as array per WordPress core specifications.
Fixes themeum#2355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
apply_filters('login_form_middle')call in both login form templates was passing an empty string ('') as the second argument instead of anarray. This causes fatal errors (TypeError) when third-party plugins — such as hCaptcha for WordPress — register a callback on this filter with a type-hintedarray $argsparameter, which is what WordPress core specifies.Root Cause
Per WordPress core, the
login_form_middlefilter signature is:Tutor passes:
Changes Made
templates/login-form.php:71— Changed second argument from''toarray()templates/login-form-legacy.php:70— Same fixTesting Instructions
login_form_middlewith a type-hinted array parameter (e.g., hCaptcha for WordPress)Does this PR change what data or activity we track or use?
No.
Fixes #2355