Conversation
shewa12
changed the title
harunollyo
requested changes
Aug 5, 2026
|
|
||
| // Save sort order. | ||
| $answer_order++; | ||
| ++$answer_order; |
Collaborator
There was a problem hiding this comment.
The post-increment was changed to a pre-increment. Was this intentional?
| foreach ( $questions as $question ) { | ||
| $data_status = isset( $question[ self::TRACKING_KEY ] ) ? $question[ self::TRACKING_KEY ] : self::FLAG_NO_CHANGE; | ||
| $question_order++; | ||
| ++$question_order; |
| $quiz_id = wp_insert_post( $quiz_data ); | ||
| do_action( ( $is_update ? 'tutor_quiz_updated' : 'tutor_initial_quiz_created' ), $quiz_id ); | ||
|
|
||
| if ( $quiz_id ) { |
Collaborator
There was a problem hiding this comment.
Please move all validation and authority check login inside validate_payload method
| } | ||
|
|
||
| // Validate deleted answer ids are valid. | ||
| if ( $deleted_answer_ids ) { |
| 'edit_others_tutor_courses', | ||
| 'edit_others_tutor_lessons', | ||
| 'edit_others_tutor_quizzes', | ||
| 'edit_others_tutor_questions', |
Collaborator
There was a problem hiding this comment.
add this
edit_others_tutor_assignments
| } | ||
|
|
||
| update_option( 'tutor_removed_edit_other_items_permission', true, false ); | ||
| } |
Collaborator
There was a problem hiding this comment.
Remove edit_others_tutor_assignments from method register_assignments_post_types
| } | ||
|
|
||
| update_option( 'tutor_removed_edit_other_items_permission', true, false ); | ||
| } |
Collaborator
There was a problem hiding this comment.
We need remove edit_others_tutor_courses from CourseBundle.php file also.
harunollyo
requested changes
Aug 6, 2026
| if ( is_null( $this->current_quiz_question_ids ) && $this->current_quiz ) { | ||
| $questions = $this->current_quiz->questions; | ||
| if ( $questions ) { | ||
| $this->current_quiz_question_ids = wp_list_pluck( $questions, 'question_id' ); |
Collaborator
There was a problem hiding this comment.
Add this line for type safety comparison later.
$this->current_quiz_question_ids = array_map( 'intval', $this->current_quiz_question_ids );| $quiz_details = $this->current_quiz->questions; | ||
|
|
||
| $quiz_question_answer = wp_list_pluck( $quiz_details, 'question_answers' ); | ||
| $this->current_quiz_answer_ids = wp_list_pluck( array_merge( ...$quiz_question_answer ), 'answer_id' ); |
Collaborator
There was a problem hiding this comment.
same for this
$this->current_quiz_answer_ids = array_map( 'intval', $this->current_quiz_answer_ids );
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/9018365849/86eyh66dt
https://app.clickup.com/t/9018365849/86eyeemr3