V2 CLI: separate new and init commands - #983
Conversation
separates 'new' and 'init' commands separates 'new' and 'init' commands
new and `init commandsnew and init commands
|
Thank you for the submission! This seems like a nice improvement to me. I have two requests:
Thanks again! |
new and init commandsnew and init commands
|
The last two commits should hopefully fix the warnings clippy was throwing, most of them concerning the pattern However, I could not fix one of them without setting #[allow(clippy::write_literal)]
writeln!(
file,
"{}", // <= works around {} fussiness in Rust format strings
r#"\newwrite\w
\immediate\openout\w=first.demo\relax
\immediate\write\w{content-un}
\immediate\closeout\w
\immediate\openout\w=second.demo\relax
\immediate\write\w{content-deux}
\immediate\closeout\w
"#Without it, clippy went into a kind of a loop, asking for more and more curly braces around Edit: |
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
=========================================
Coverage ? 45.17%
=========================================
Files ? 148
Lines ? 62159
Branches ? 0
=========================================
Hits ? 28083
Misses ? 34076
Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pkgw
left a comment
There was a problem hiding this comment.
Thanks! There's one small thing to fix in the new docs.
As for the Clippy stuff, thanks — when I initially asked there was only one small error, so you ended up doing a lot more work than I wanted to ask of you!
I'll look into the MSVC issue. I think it's something that might not be too hard to fix/work around. I might fix that doc title issue while I'm at it.
This is a simple quality of life change I would like to suggest, as it standardizes the CLI of tectonic with that of tools such as
cargoorpoetry. Not much else to say, tbh.