Skip to content

Don't wrap diagnostic warnings - #803

Merged
pkgw merged 1 commit into
tectonic-typesetting:masterfrom
ralismark:unwrapped-warnings
Jul 4, 2021
Merged

Don't wrap diagnostic warnings#803
pkgw merged 1 commit into
tectonic-typesetting:masterfrom
ralismark:unwrapped-warnings

Conversation

@ralismark

Copy link
Copy Markdown
Contributor

The print_ln() calls in the original code would also output newlines to the current diagnostic. Changing it to directly print newlines fixes this issue (though interestingly, the code for the SELECTOR_TERM_AND_LOG already did this). This change shouldn't affect the contents of the tex log, only the nicer-looking warnings that get printed to the terminal.

Fixes #684, I think, though that issue might be referring to the actual tex log that's being printed to rust_stdout.

@codecov

codecov Bot commented Jul 3, 2021

Copy link
Copy Markdown

Codecov Report

Merging #803 (d887c1b) into master (d62a828) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #803   +/-   ##
=======================================
  Coverage   46.94%   46.94%           
=======================================
  Files         146      146           
  Lines       59356    59358    +2     
=======================================
+ Hits        27862    27863    +1     
- Misses      31494    31495    +1     
Impacted Files Coverage Δ
crates/engine_xetex/xetex/xetex-output.c 82.56% <66.66%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62a828...d887c1b. Read the comment docs.

@pkgw

pkgw commented Jul 4, 2021

Copy link
Copy Markdown
Collaborator

Thanks!

@pkgw
pkgw merged commit 11cec0e into tectonic-typesetting:master Jul 4, 2021
@pkgw pkgw mentioned this pull request Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

option: don't add newline

2 participants