Tectonic.toml: preamble, index and postamble - #746
Conversation
This enables the use of preamble, index and postamble keys in an output. These get built together to form the input buffer and default to the current defaults too. There isn't any fancy checking here as we defer it to the latex engine. In theory this could enable injection but I'm not aware that would be a concern at the moment.
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 46.80% 46.86% +0.05%
==========================================
Files 118 118
Lines 53707 53742 +35
==========================================
+ Hits 25139 25185 +46
+ Misses 28568 28557 -11
Continue to review full report at Codecov.
|
|
Thank you! At first blush this looks good, and I really appreciate you adding some test coverage. Would you be able to go even a step farther and document the new settings in the reference? I'm pretty oversubscribed this week so it might be a bit before I can do a full review. Please ping me if it's been a little while. |
|
Thanks for taking a quick look. I've now added some documentation, happy for comments :) |
|
Sorry, this is taking me even longer than expected to get to. If anyone else wants to do a code review they are more than welcome to offer their opinion! |
|
After such a long wait ... this looks great! Thank you! My apologies for taking so long to review and merge this .. if it's any consolation, it's not like I've been working on anything else Tectonic-related in the meantime ... |
This enables the use of preamble, index and postamble keys in an output.
These get built together to form the input buffer and default to the
current defaults too.
There isn't any fancy checking here as we defer it to the latex engine.
In theory this could enable injection but I'm not aware that would be a
concern at the moment.
Fixes #745