Add open document option - #733
Conversation
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 46.83% 46.83%
=======================================
Files 130 130
Lines 59683 59700 +17
=======================================
+ Hits 27951 27963 +12
- Misses 31732 31737 +5
Continue to review full report at Codecov.
|
pkgw
left a comment
There was a problem hiding this comment.
Thanks so much! This looks great and I just have a few comments.
- It would be great to get some test coverage, although I can see how that might be tricky with the behavior that's being added here. Maybe the
opencrate has some test infrastructure that we can copy? - It would also be great to add the new option to the docs in
docs/src/v2cli/build.md
Below I've also made a few very small comments.
|
I've added the docs and addressed the comments. Regarding testing I've added one with the |
|
Brilliant! Now that I have awesome release automation I try to get contributions into releases quickly, but FYI it will take a little while as I work through the infrastructural changes that I've been pursuing. |
Fixes #109
Adds the
--openoption to thebuildsubcommand of the new v2 cli.