Skip to content

Add open document option - #733

Merged
pkgw merged 6 commits into
tectonic-typesetting:masterfrom
jeffa5:add-open-option
Jan 12, 2021
Merged

Add open document option#733
pkgw merged 6 commits into
tectonic-typesetting:masterfrom
jeffa5:add-open-option

Conversation

@jeffa5

@jeffa5 jeffa5 commented Jan 11, 2021

Copy link
Copy Markdown

Fixes #109

Adds the --open option to the build subcommand of the new v2 cli.

@codecov

codecov Bot commented Jan 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #733 (0d0c051) into master (21aaecb) will increase coverage by 0.00%.
The diff coverage is 70.58%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #733   +/-   ##
=======================================
  Coverage   46.83%   46.83%           
=======================================
  Files         130      130           
  Lines       59683    59700   +17     
=======================================
+ Hits        27951    27963   +12     
- Misses      31732    31737    +5     
Impacted Files Coverage Δ
src/document.rs 69.23% <69.23%> (+0.13%) ⬆️
src/bin/tectonic/v2cli.rs 78.04% <75.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21aaecb...0d0c051. Read the comment docs.

@pkgw pkgw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! This looks great and I just have a few comments.

  1. It would be great to get some test coverage, although I can see how that might be tricky with the behavior that's being added here. Maybe the open crate has some test infrastructure that we can copy?
  2. It would also be great to add the new option to the docs in docs/src/v2cli/build.md

Below I've also made a few very small comments.

Comment thread Cargo.toml Outdated
Comment thread src/document.rs Outdated
Comment thread src/document.rs Outdated
@jeffa5

jeffa5 commented Jan 12, 2021

Copy link
Copy Markdown
Author

I've added the docs and addressed the comments.

Regarding testing I've added one with the BROWSER environment variable set. This seems to work with not opening the document and passes the test but the open crate doesn't seem to have any tests either.

@pkgw

pkgw commented Jan 12, 2021

Copy link
Copy Markdown
Collaborator

Brilliant!

Now that I have awesome release automation I try to get contributions into releases quickly, but FYI it will take a little while as I work through the infrastructural changes that I've been pursuing.

@pkgw
pkgw merged commit 2ab196b into tectonic-typesetting:master Jan 12, 2021
@jeffa5
jeffa5 deleted the add-open-option branch January 12, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open PDF after build

2 participants