Defuse the linebreaker in semantic pagination mode - #245
Merged
Conversation
…ntinue statements in try_break()
After much, much time spent trying to understand the linebreaking algorithm, I think I am confident in the right way to modify it to activate semantic pagination mode. Here it is! A quick test on xenia has visual results exactly as I was hoping: a very "short" document with normal-looking paragraph lines flying off the edge of the page. Huzzah!
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 39.87% 39.89% +0.01%
==========================================
Files 133 133
Lines 63742 63785 +43
==========================================
+ Hits 25419 25448 +29
- Misses 38323 38337 +14
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally figured out the linebreaking algorithm well enough to think that I know the correct way to do this. The new functionality isn't testable as yet without hacking the code a bit — but if you hack the code to activate the
semantic_pagination_enabledcodepaths inxetex-linebreak.cwithout turning on the other ones, you can get an output PDF with zany paragraphs shooting off the edge of the page, as intended by this feature.