Fix various small issues in driver module. - #184
Merged
Conversation
This makes some fields public, so that it's possible to get interesting information out of IoEvents. Also, fixes the behaviour of ProcessingSessionBuilder::output_dir to match its documentation (i.e., don't panic if the output_dir is not provided).
Collaborator
|
Looks great, will merge as soon as CI passes. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 37.97% 38.15% +0.18%
==========================================
Files 131 131
Lines 60830 60974 +144
==========================================
+ Hits 23099 23264 +165
+ Misses 37731 37710 -21
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes some fields public, so that it's possible to get interesting
information out of IoEvents. Also, fixes the behaviour of
ProcessingSessionBuilder::output_dir to match its documentation (i.e.,
don't panic if the output_dir is not provided).