Cleanup handling of unicode filenames - #165
Merged
Merged
Conversation
Collaborator
|
I'm sorry, I have no idea why I never followed up this PR. I will see if I can rebase it onto the current master. |
looks to be introduced by bcdc052.
Mrmaxmeier
force-pushed
the
cleanup-unicode
branch
from
September 20, 2018 17:55
10ecf4d to
4ea5dab
Compare
Collaborator
|
This is awesome! Thanks for a great contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the
name_of_filevariable by keeping it utf8-encoded instead of converting to utf16.Previously filenames with low non-ascii characters like
öbe wrongly processed while characters outside of the BMP range that require two utf16 code-points (like emojis) would cause segfaults.With this patch tectonic now happily writes to
hallöchen 🐨 welt 🌍.pdfinstead of crashing.