Fix v2 cli flag being incorrectly applied - #1270
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
==========================================
- Coverage 47.03% 47.03% -0.01%
==========================================
Files 184 184
Lines 66302 66309 +7
Branches 66302 66309 +7
==========================================
Hits 31188 31188
- Misses 35114 35121 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CraftSpider
requested changes
Jun 23, 2025
CraftSpider
left a comment
CraftSpider
left a comment
Contributor
There was a problem hiding this comment.
Please rebase and fix conflicts. Once that's done, this looks good to merge. Had a single nit comment, but that can also be fixed later.
mky2
force-pushed
the
watch
branch
2 times, most recently
from
June 23, 2025 18:51
84fe96c to
e63f35e
Compare
CraftSpider
approved these changes
Jun 23, 2025
Contributor
|
Looks good! Thanks for the patience with the 2-month review lag. |
CraftSpider
enabled auto-merge
June 23, 2025 18:59
Contributor
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem with the watch command when using v2 cli with a symlink named
nextonic.