Keep logs on error if --keep-logs provided - #103
Merged
Conversation
Collaborator
|
Looks great! |
Mrmaxmeier
pushed a commit
to Mrmaxmeier/tectonic
that referenced
this pull request
Oct 1, 2019
Implement Write and Read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements what is, I believe, the expected behavior of
--keep-logs: Even if the xetex engine errors out, the logs are saved. This matches the tex standard and has at least two uses:Sometimes it is necessary to inspect the logs to understand why an error occurred.
Editors, for instance
vimwithvim-latex, use the logs to locate errors and warnings.A simple test is also provided.
I basically just extracted the code in
runmethod that saves the outputs, etc., intowrite_filesand added a parameteronly_logs.