Do not change the extension of files requested by the engine. - #100
Merged
Conversation
Fixes a regression caused by `7c2e4e622dde666a038154a9c925829e309a988f`, for instance for `tests/xenia/paper.tex`.
Collaborator
|
Thanks for fixing this so quickly! I should have tested more carefully. |
Mrmaxmeier
pushed a commit
to Mrmaxmeier/tectonic
that referenced
this pull request
Oct 1, 2019
cleanup known_specials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression caused by 7c2e4e6, for instance for
tests/xenia/paper.tex.Specifically, now tectonic tries to add default file format extensions only if the requested file does not have an extension already.
As I mentioned in #93, I believe that tectonic should not change the extension of files requested by a tex code, for instance return
natbib.styinstead ofnatbib.cfg.I also cleaned up the code to minimize allocations.