CSAM: Expose/update services - #563
Merged
Merged
Conversation
…and show attached csam reports
murilovmachado
approved these changes
Dec 15, 2021
| type CreateCSAMReportParams = { | ||
| csamReportId: string; | ||
| twilioWorkerId: string; | ||
| contactId?: number; |
Contributor
There was a problem hiding this comment.
What's contactId? Is it something from CSAM or from Aselo?
Nevermind, it's the id from our own contacts table, right?
Collaborator
Author
There was a problem hiding this comment.
Yes, it's the foreign key
Collaborator
|
LGTM but I'm always hesitant to approve a PR with a failing build :-) Approving, but it would be nice if we can try to split PRs in a way so that they pass individually wherever possible |
stephenhand
approved these changes
Dec 21, 2021
nickhurlburt
approved these changes
Dec 22, 2021
nickhurlburt
left a comment
nickhurlburt
left a comment
Collaborator
There was a problem hiding this comment.
Ditto Steve - when possible, good to have the build run successfully
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of "splitting #543 in smaller chunks".
Primary reviewer: @murilovmachado
Note: is easier to review commit-per-commit.
This PR:
createCSAMReportfunction to create csam reports in HRM (CSAM IWF reporting from Aselo: backend hrm#131).csamReportswhen creating a new case in HRM (CSAM IWF reporting from Aselo: backend hrm#131).reportToIWFserverless endpoint (IWF API integration).Note: CI failing due to lint. This will be fixed in subsequent PRs.