Skip to content

๐Ÿ”€ :: (#794) agp ์—…๊ทธ๋ ˆ์ด๋“œ - #796

Merged
uson1004 merged 2 commits into
developfrom
setting/794-agp-์—…๊ทธ๋ ˆ์ด๋“œ
Nov 24, 2025

Hidden character warning

The head ref may contain hidden characters: "setting/794-agp-\uc5c5\uadf8\ub808\uc774\ub4dc"
Merged

๐Ÿ”€ :: (#794) agp ์—…๊ทธ๋ ˆ์ด๋“œ#796
uson1004 merged 2 commits into
developfrom
setting/794-agp-์—…๊ทธ๋ ˆ์ด๋“œ

Conversation

@uson1004

@uson1004 uson1004 commented Nov 24, 2025

Copy link
Copy Markdown
Member

๊ฐœ์š”

gradle ๋ฒ„์ „์„ ์—…๊ทธ๋ ˆ์ด๋“œ ํ•ฉ๋‹ˆ๋‹ค

์ž‘์—…์‚ฌํ•ญ

  • 8.3.2๋กœ ์—…๊ทธ๋ ˆ์ด๋“œ
  • ๋„ค๋น„๊ฒŒ์ด์…˜ 3 ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์ถ”๊ฐ€

์ถ”๊ฐ€ ๋กœ ํ•  ๋ง

Summary by CodeRabbit

  • Chores
    • Updated Android Gradle Plugin to version 8.3.2
    • Upgraded Gradle wrapper to version 8.4 for improved build performance
    • Added navigation component library version 1.0 with runtime and UI modules

โœ๏ธ Tip: You can customize this high-level summary in your review settings.

@uson1004 uson1004 self-assigned this Nov 24, 2025
@uson1004 uson1004 added the setting ํ”„๋กœ์ ํŠธ์˜ ๊ธฐ๋ณธ์ ์ธ ์„ค์ •์„ ํ•  ๊ฒฝ์šฐ label Nov 24, 2025
@uson1004 uson1004 linked an issue Nov 24, 2025 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Nov 24, 2025

Copy link
Copy Markdown

Walkthrough

This PR updates build infrastructure and dependencies across three files. The Gradle wrapper is bumped from 8.2 to 8.4, AGP is upgraded from 8.2.2 to 8.3.2, new Navigation 3 library dependencies (runtime and UI modules at 1.0.0) are introduced, and a local property helper is refactored to use the providers API.

Changes

Cohort / File(s) Summary
Gradle build tool updates
gradle/wrapper/gradle-wrapper.properties
Updated Gradle wrapper distribution URL from gradle-8.2-bin.zip to gradle-8.4-bin.zip
Dependency and plugin versions
gradle/libs.versions.toml
Bumped AGP from 8.2.2 to 8.3.2; introduced new navigation3 version alias (1.0.0); added two new library declarations for androidx-navigation3-runtime and androidx-navigation3-ui
Build script property handling
network/build.gradle.kts
Updated localProperty helper to pass providers argument to gradleLocalProperties() call

Estimated code review effort

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~10 minutes

  • Dependency and version bumps are mechanical changes
  • Library declaration additions follow a consistent pattern
  • Single-argument API update in build script requires minimal verification

Poem

๐Ÿฐ Dependencies dance, versions aligned,
Navigation three, a new path defined,
Gradle upgraded, Kotlin scripts refinedโ€”
Build tools harmonized, configurations intertwined!

Pre-merge checks and finishing touches

โœ… Passed checks (3 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title check โœ… Passed The title '๐Ÿ”€ :: (#794) agp ์—…๊ทธ๋ ˆ์ด๋“œ' clearly indicates AGP upgrade, which aligns with the main change (AGP 8.2.2 โ†’ 8.3.2), though it uses emoji and non-English text.
Docstring Coverage โœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
โœจ Finishing touches
  • ๐Ÿ“ Generate docstrings
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch setting/794-agp-์—…๊ทธ๋ ˆ์ด๋“œ

๐Ÿ“œ Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 588af75 and ba28e99.

๐Ÿ“’ Files selected for processing (3)
  • gradle/libs.versions.toml (3 hunks)
  • gradle/wrapper/gradle-wrapper.properties (1 hunks)
  • network/build.gradle.kts (1 hunks)
โฐ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Agent
๐Ÿ”‡ Additional comments (4)
gradle/libs.versions.toml (2)

26-26: AGP version upgrade approved.

The AGP update from 8.2.2 to 8.3.2 is a reasonable minor version bump. Ensure your project builds successfully and runs through your test suite with this version.


40-40: Navigation 3 v1.0.0 is stable and compatibleโ€”no action required.

Navigation 3 v1.0.0 is a stable release suitable for production, so the initial concern about it being experimental is outdated. Your project's AGP 8.3.2 and Gradle 8.4 versions are compatible with Navigation 3. Both androidx.navigation 2.7.7 and navigation3 1.0.0 coexisting is intentional: Nav3 is built specifically for Compose while Nav2 continues for Fragment/View-based apps, supporting gradual migration.

gradle/wrapper/gradle-wrapper.properties (1)

4-4: Gradle 8.4 is required for AGP 8.3.2.

AGP 8.3.2 requires Gradle 8.4 (minimum), so this change is correct and necessaryโ€”not a case of the wrapper being ahead of AGP. No further verification needed.

Likely an incorrect or invalid review comment.

network/build.gradle.kts (1)

108-109: Based on my verification, the change to gradleLocalProperties(rootDir, providers) is the recommended approach since Android Studio LadyBug (circa 2023/09), and the providers parameter is required when upgrading to AGP 8.3.0 and later.

However, the only available import path is com.android.build.gradle.internal.cxx.configure.gradleLocalProperties, and web searches reveal no public API alternative. The internal API path appears to be the standard pattern documented across multiple Stack Overflow discussions and Android developer communities.

No public API alternative exists; internal API usage is unavoidable here.

The code correctly implements the required pattern for AGP 8.3.2 with proper providers integration. While the internal API is not ideal, it is the only available mechanism for reading local.properties in this version.

Tip

๐Ÿ“ Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests โ€” including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. ๐Ÿ“ Description โ€” Summarize the main change in 50โ€“60 words, explaining what was done.
  2. ๐Ÿ““ References โ€” List relevant issues, discussions, documentation, or related PRs.
  3. ๐Ÿ“ฆ Dependencies & Requirements โ€” Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. ๐Ÿ“Š Contributor Summary โ€” Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. โœ”๏ธ Additional Notes โ€” Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Android Gradle Plugin (AGP) from version 8.2.2 to 8.3.2 and Gradle from 8.2 to 8.4. The changes include necessary API updates for compatibility with the new AGP version and add Navigation 3 library dependencies.

  • Updated AGP to 8.3.2 and Gradle wrapper to 8.4
  • Modified gradleLocalProperties API call to include the providers parameter (required for AGP 8.3+)
  • Added navigation3 library dependencies for runtime and UI components

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
gradle/libs.versions.toml Updated AGP version to 8.3.2 and added navigation3 library version and dependency declarations
gradle/wrapper/gradle-wrapper.properties Updated Gradle distribution URL from version 8.2 to 8.4
network/build.gradle.kts Updated gradleLocalProperties function call to include providers parameter for AGP 8.3+ compatibility

๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gradle/libs.versions.toml
androidx-compose-material = { group = "androidx.compose.material3", name = "material3", version.ref = "materialCompose" }
androidx-compose-material-window = { group = "androidx.compose.material3", name = "material3-window-size-class-android", version.ref = "materialCompose" }
androidx-navigation-compose = { module = "androidx.navigation:navigation-compose", version.ref = "navigation" }
androidx-navigation3-runtime = { module = "androidx.navigation3:navigation3-runtime", version.ref = "navigation3" }

Copilot AI Nov 24, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name androidx.navigation3:navigation3-runtime does not exist. The AndroidX Navigation library uses the package name androidx.navigation:navigation-runtime, even for version 3.x.

The correct declaration should be:

androidx-navigation3-runtime = { module = "androidx.navigation:navigation-runtime", version.ref = "navigation3" }
Suggested change
androidx-navigation3-runtime = { module = "androidx.navigation3:navigation3-runtime", version.ref = "navigation3" }
androidx-navigation3-runtime = { module = "androidx.navigation:navigation-runtime", version.ref = "navigation3" }

Copilot uses AI. Check for mistakes.
Comment thread gradle/libs.versions.toml
androidx-compose-material-window = { group = "androidx.compose.material3", name = "material3-window-size-class-android", version.ref = "materialCompose" }
androidx-navigation-compose = { module = "androidx.navigation:navigation-compose", version.ref = "navigation" }
androidx-navigation3-runtime = { module = "androidx.navigation3:navigation3-runtime", version.ref = "navigation3" }
androidx-navigation3-ui = { module = "androidx.navigation3:navigation3-ui", version.ref = "navigation3" }

Copilot AI Nov 24, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name androidx.navigation3:navigation3-ui does not exist. The AndroidX Navigation library uses the package name androidx.navigation:navigation-ui, even for version 3.x.

The correct declaration should be:

androidx-navigation3-ui = { module = "androidx.navigation:navigation-ui", version.ref = "navigation3" }
Suggested change
androidx-navigation3-ui = { module = "androidx.navigation3:navigation3-ui", version.ref = "navigation3" }
androidx-navigation3-ui = { module = "androidx.navigation:navigation-ui", version.ref = "navigation3" }

Copilot uses AI. Check for mistakes.
@uson1004
uson1004 merged commit 74d41a6 into develop Nov 24, 2025
7 checks passed
@uson1004
uson1004 deleted the setting/794-agp-์—…๊ทธ๋ ˆ์ด๋“œ branch November 24, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

setting ํ”„๋กœ์ ํŠธ์˜ ๊ธฐ๋ณธ์ ์ธ ์„ค์ •์„ ํ•  ๊ฒฝ์šฐ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AGP ์—…๊ทธ๋ ˆ์ด๋“œ

2 participants