Convert array grouping tests to static methods - #3830
Merged
Conversation
12 tasks
jridgewell
approved these changes
May 19, 2023
Contributor
|
Can you double check the CI output? |
Member
Author
|
Thanks, updated. |
ptomato
approved these changes
May 31, 2023
ptomato
left a comment
ptomato
left a comment
Contributor
There was a problem hiding this comment.
We reviewed this in the maintainers meeting. 😄
10 tasks
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deleted tests related to arraylikes and sparse arrays and ToLength, and added two tests around iterables.