Skip to content

chore: sync upstream main - #134

Merged
tarik02 merged 6 commits into
mainfrom
sync-upstream-main-20260814-2
Aug 14, 2026
Merged

chore: sync upstream main#134
tarik02 merged 6 commits into
mainfrom
sync-upstream-main-20260814-2

Conversation

@tarik02

@tarik02 tarik02 commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Merged five upstream commits through pingdotgg/t3code@196c8ea0d.
  • Adopted the faster Windows update layout, with server.asar kept packed for the primary backend and extracted on demand for WSL.
  • Included terminal PID polling and web copy fixes plus the updated desktop status indicator and sidebar tooltips.
  • Preserved fork canary release notes and Win32 path behavior in the overlapping update and desktop test code.

Why

Brings the fork to current upstream after #133 without dropping fork-specific release-channel behavior.

UI Changes

This includes upstream update-indicator and tooltip changes. Screenshots were not captured because browser verification was not requested.

Verification

  • lowio corepack pnpm install --frozen-lockfile
  • lowio vp run --filter @t3tools/desktop --filter @t3tools/web --concurrency-limit 2 typecheck
  • lowio vp test run apps/desktop/src/backend/DesktopBackendConfiguration.test.ts, 23 tests passed
  • lowio vp lint --report-unused-disable-directives apps/desktop/src/backend/DesktopBackendConfiguration.test.ts apps/web/src/components/sidebar/SidebarUpdatePill.tsx

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Made with gpt-5.6-sol using the Codex harness in T3 Code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 14, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a472540c74

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/localApi.ts
Comment on lines +81 to +84
close: async () => {
if (!window.desktopBridge) {
dismissContextMenu();
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Dismiss fallback menus in Electron custom mode

When the desktop context-menu preference is custom, show() uses showContextMenuFallback() even though window.desktopBridge exists, but this guard makes close() a no-op. Consequently, clearing a terminal selection leaves its fallback menu and pending promise open until the user clicks elsewhere or presses Escape. Call dismissContextMenu() regardless of bridge presence; it already does nothing when no fallback menu is active.

AGENTS.md reference: AGENTS.md:L25-L31

Useful? React with 👍 / 👎.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 10.7 KiB 10.5 KiB −216 B (−2.0%) 15.1 KiB
Codex Thread snapshot wire 4.8 KiB 4.8 KiB +5 B (+0.1%) 7.3 KiB
Codex Live turn WebSocket wire 5.9 KiB 5.7 KiB −221 B (−3.6%) 7.8 KiB
Codex Live turn WebSocket decoded 51.7 KiB 50.2 KiB −1.5 KiB (−2.9%) 66.4 KiB
Codex Live turn messages 11 9 −2 (−18.2%) 21
Claude Total thread wire 10.7 KiB 10.5 KiB −259 B (−2.4%) 15.1 KiB
Claude Thread snapshot wire 4.8 KiB 4.8 KiB +1 B (+0.0%) 7.3 KiB
Claude Live turn WebSocket wire 5.9 KiB 5.7 KiB −260 B (−4.3%) 7.8 KiB
Claude Live turn WebSocket decoded 52.6 KiB 51.1 KiB −1.5 KiB (−2.9%) 66.4 KiB
Claude Live turn messages 11 9 −2 (−18.2%) 21

Baseline: ba75303 · PR result: dff1279 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 76.2 KiB
  • Claude decoded thread snapshot: 76.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

# Conflicts:
#	apps/desktop/src/backend/DesktopBackendConfiguration.test.ts
#	apps/web/src/components/sidebar/SidebarUpdatePill.tsx
#	pnpm-lock.yaml
@tarik02
tarik02 force-pushed the sync-upstream-main-20260814-2 branch from a472540 to dff1279 Compare August 14, 2026 20:38
@tarik02
tarik02 merged commit a89fe16 into main Aug 14, 2026
12 checks passed
@tarik02 tarik02 mentioned this pull request Aug 17, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants