Skip to content

enh: Wrapper Library Add Hint Message(3.3.6 branch) - #33270

Merged
zitsen merged 1 commit into
3.3.6from
enh/TD-38301-3.3.6
Oct 17, 2025
Merged

enh: Wrapper Library Add Hint Message(3.3.6 branch)#33270
zitsen merged 1 commit into
3.3.6from
enh/TD-38301-3.3.6

Conversation

@DuanKuanJun

Copy link
Copy Markdown
Contributor

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @DuanKuanJun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the TDengine client wrapper library by implementing a comprehensive error hinting system. The primary goal is to improve the user experience during debugging by providing clear, context-specific suggestions when dynamic link libraries or their functions fail to load. This involves distinguishing between different types of loading failures and offering platform-specific troubleshooting steps, making it easier for users to resolve common setup and configuration issues.

Highlights

  • New Error Hinting Mechanism: Introduced a new wrapperHint module to provide more descriptive and actionable error messages when the TDengine client driver or its functions fail to load.
  • Improved Error Specificity: Error handling macros in wrapperFunc.c were updated to differentiate between the entire DLL/shared library failing to load and specific functions within a loaded library not being found, using TSDB_CODE_DLL_FUNC_NOT_LOAD.
  • Platform-Specific Guidance: The new hinting system includes platform-specific error messages and common solutions for Linux and Windows operating systems, addressing typical shared library loading issues like file not found, permission denied, or corrupted files.
  • Integration into Driver Loading: The showWrapperHint function is now called in wrapperDriver.c whenever there's a failure to load the TDengine driver or any of its required functions, providing immediate user feedback.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable enhancement by adding hint messages for wrapper library errors, which will significantly improve the user experience when troubleshooting loading issues. The implementation is solid, introducing new files for hint logic and correctly integrating them. I've provided a few suggestions to enhance code quality and maintainability, such as using symbolic constants for error codes, improving documentation, and properly scoping helper functions. The introduction of the TSDB_CODE_DLL_FUNC_NOT_LOAD error code is also a positive change for more precise error reporting.

Comment thread source/client/wrapper/inc/wrapperHint.h
Comment thread source/client/wrapper/src/wrapperHint.c
Comment thread source/client/wrapper/src/wrapperHint.c
Comment thread source/client/wrapper/src/wrapperHint.c
Comment thread source/client/wrapper/src/wrapperHint.c
@DuanKuanJun DuanKuanJun changed the title enh: Wrapper Library Add Hint Message enh: Wrapper Library Add Hint Message(3.3.6 branch) Oct 16, 2025
@zitsen
zitsen merged commit cb41802 into 3.3.6 Oct 17, 2025
13 of 14 checks passed
@zitsen
zitsen deleted the enh/TD-38301-3.3.6 branch October 17, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants