Skip to content

style(ui-components): Improve modal scrollable behavior#2952

Merged
AtelyPham merged 2 commits into
developfrom
trung-tin/improve-modal-scrollable-behavior
Apr 4, 2025
Merged

style(ui-components): Improve modal scrollable behavior#2952
AtelyPham merged 2 commits into
developfrom
trung-tin/improve-modal-scrollable-behavior

Conversation

@AtelyPham

Copy link
Copy Markdown
Contributor

Summary of changes

Provide a detailed description of proposed changes.

  • Improve modal scrolling.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • apps/leaderboard
  • libs/tangle-shared-ui
  • libs/ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

  • Closes NaN.

Screen Recording

Before

CleanShot.2025-04-04.at.16.35.38.mp4

After

CleanShot.2025-04-04.at.16.36.16.mp4

@AtelyPham AtelyPham self-assigned this Apr 4, 2025
@AtelyPham AtelyPham requested a review from devpavan04 as a code owner April 4, 2025 09:40
@github-project-automation github-project-automation Bot moved this to Not Started 🕧 in Tangle Universe Apr 4, 2025
@AtelyPham AtelyPham moved this from Not Started 🕧 to Building 🏗️ in Tangle Universe Apr 4, 2025
@netlify

netlify Bot commented Apr 4, 2025

Copy link
Copy Markdown

Deploy Preview for tangle-leaderboard ready!

Name Link
🔨 Latest commit 5292051
🔍 Latest deploy log https://app.netlify.com/sites/tangle-leaderboard/deploys/67efa9074d5929000800b918
😎 Deploy Preview https://deploy-preview-2952--tangle-leaderboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Apr 4, 2025

Copy link
Copy Markdown

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 5292051
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67efa907573e6f0008cba4ec
😎 Deploy Preview https://deploy-preview-2952--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Apr 4, 2025

Copy link
Copy Markdown

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 5292051
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67efa9073c286a0008b0c2ce
😎 Deploy Preview https://deploy-preview-2952--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danielbui12 danielbui12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation Bot moved this from Building 🏗️ to Completed ✅ in Tangle Universe Apr 4, 2025
@AtelyPham AtelyPham merged commit 0270a42 into develop Apr 4, 2025
@AtelyPham AtelyPham deleted the trung-tin/improve-modal-scrollable-behavior branch April 4, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Completed ✅

Development

Successfully merging this pull request may close these issues.

2 participants