Skip to content

refactor(tangle-cloud): update operator blueprint registration page#2937

Merged
drewstone merged 7 commits into
developfrom
daniel/implement-operator-register-blueprint
Apr 1, 2025
Merged

refactor(tangle-cloud): update operator blueprint registration page#2937
drewstone merged 7 commits into
developfrom
daniel/implement-operator-register-blueprint

Conversation

@danielbui12

Copy link
Copy Markdown
Contributor

Summary of changes

Provide a detailed description of proposed changes.

  • Separate registration review page
  • Update registration hook

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • apps/leaderboard
  • libs/tangle-shared-ui
  • libs/ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

Screen.Recording.2025-03-27.at.15.04.14.mov

@netlify

netlify Bot commented Mar 27, 2025

Copy link
Copy Markdown

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 0c736b6
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67e766a172174e000801b9ff
😎 Deploy Preview https://deploy-preview-2937--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Mar 27, 2025

Copy link
Copy Markdown

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 0c736b6
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67e766a10ad9c10008e9e3a0
😎 Deploy Preview https://deploy-preview-2937--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Mar 27, 2025

Copy link
Copy Markdown

Deploy Preview for tangle-leaderboard canceled.

Name Link
🔨 Latest commit d0468cb
🔍 Latest deploy log https://app.netlify.com/sites/tangle-leaderboard/deploys/67e50934484a860008d97fc2

@drewstone

Copy link
Copy Markdown
Contributor

Font sizes are a bit weird. The blueprint name is could be a tad bit larger. Alice or the account in question is even tinier than our most tiny fonts.

@drewstone

Copy link
Copy Markdown
Contributor

Otherwise great work getting the logic hooked up.

@drewstone

Copy link
Copy Markdown
Contributor

I think the dropdowns where we input how much to register/bond and the TTL and other params can actually be removed and not a dropdown. Creates more unncessary button clicks. Just show this form expanded by default?

@netlify

netlify Bot commented Mar 29, 2025

Copy link
Copy Markdown

Deploy Preview for tangle-leaderboard ready!

Name Link
🔨 Latest commit 0c736b6
🔍 Latest deploy log https://app.netlify.com/sites/tangle-leaderboard/deploys/67e766a15fa2a900084786f9
😎 Deploy Preview https://deploy-preview-2937--tangle-leaderboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danielbui12

Copy link
Copy Markdown
Contributor Author

@drewstone agreed! does it look better now?

Screenshot 2025-03-29 at 09 56 12

@danielbui12

Copy link
Copy Markdown
Contributor Author

@AtelyPham I found a bug on Input component. My expectation is when I pressed tab, it should have been focus on the next input.

For example of my expectation.

Screen.Recording.2025-03-29.at.09.39.26.mov

I've tried, but I couldn't find a solution. Could you please take a look?

The current state is really weird, I have to use mouse to click everytime

bug_tab_input.mov

defaultValue={blueprints.length > 0 ? blueprints[0].id : undefined}
collapsible
>
<ScrollArea className="h-[417px]">

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AtelyPham no need to use ScrollArea

'data-[state=open]:slide-in-from-bottom-full md:data-[state=open]:fade-in-0 md:data-[state=open]:zoom-in-0',
'data-[state=closed]:slide-out-to-bottom-full md:data-[state=closed]:fade-out-0 md:data-[state=closed]:zoom-out-0',
'max-md:bottom-0 max-md:rounded-b-none md:top-1/2 md:-translate-y-1/2',
'max-h-[calc(100vh-66px-8rem)] overflow-y-scroll',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AtelyPham no need to use ScrollArea

Bug on styling element. This element wraps the ModalBody, so overflow should be here. No need to style min height, or ScrollArea

@drewstone drewstone merged commit 595318d into develop Apr 1, 2025
@drewstone drewstone deleted the daniel/implement-operator-register-blueprint branch April 1, 2025 05:56
@github-project-automation github-project-automation Bot moved this from Not Started 🕧 to Completed ✅ in Tangle Universe Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Completed ✅

Development

Successfully merging this pull request may close these issues.

[TASK] Refactor the blueprint registration page

2 participants