fix(tangle-cloud): update services hook to use common hook#2922
Merged
danielbui12 merged 4 commits intoMar 25, 2025
Conversation
danielbui12
requested review from
AtelyPham,
devpavan04,
monaiuu and
yuri-xyz
as code owners
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-leaderboard canceled.
|
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
drewstone
approved these changes
Mar 24, 2025
yuri-xyz
suggested changes
Mar 24, 2025
danielbui12
changed the title
useAgnosticTx hook
yuri-xyz
approved these changes
Mar 25, 2025
yuri-xyz
left a comment
yuri-xyz
left a comment
Contributor
There was a problem hiding this comment.
Nice, looks good 👍 I can see you've significantly simplified the impl. of the extrinsic calls, that's the magic of the useAgnosticTx and useSubstrateTx hooks 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Provide a detailed description of proposed changes.
useAgnosticTxhookProposed area of change
Put an
xin the boxes that apply.apps/tangle-dappapps/tangle-cloudapps/leaderboardlibs/tangle-shared-uilibs/ui-componentsAssociated issue(s)
Specify any issues that can be closed from these changes (e.g.
Closes #233).Screen Recording
If possible provide screenshots and/or a screen recording of proposed change.