fix(examples): data-creation loop must not force-accept a rejected example#389
Merged
Conversation
…ample createDataCreationLoop pushed result.winner unconditionally, but defaultSelectWinner falls back to the best-SCORING iteration even when none passed the accept rule — so on a real null (0 discriminating examples) it falsely reported the least-bad reject as accepted. Gate the push on the winner's own decision.accept; add a regression test proving the null case yields zero accepted. Surfaced by the live two-tier run (0/3).
tangletools
approved these changes
Jun 25, 2026
tangletools
left a comment
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — 42f9c2ef
Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-25T20:57:11Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agentic-data-creation example (#388) pushed
result.winnerto the accepted set unconditionally.defaultSelectWinnerreturns the best-SCORING iteration even when NONE passed the discriminative accept rule, so on a real null the loop falsely reported the least-bad reject as 'accepted'. It hid offline (scripted fixtures always pass) — surfaced by the live two-tier run that legitimately accepted 0/3. Fix: gate the push on the winner's owndecision.accept; regression test added (force-reject → 0 accepted, no false-accept). Note:typecheck:examplesneedspnpm run buildfirst (the example self-imports the built/loopssubpath).