Skip to content

Adds teosd.service to run teos as daemon - #176

Merged
sr-gi merged 1 commit into
talaia-labs:masterfrom
sr-gi:teos-service
Jan 23, 2023
Merged

sr-gi merged 1 commit into
talaia-labs:masterfrom
sr-gi:teos-service

Conversation

@sr-gi

@sr-gi sr-gi commented Jan 20, 2023

Copy link
Copy Markdown
Member

This builds on top of the work from the work by @decentralizedb and @jochemin in #138. It is mainly just re-arranging the code and readmes to fit #138 (review), but they did all the heavy lifting.

Close #138

@sr-gi sr-gi linked an issue Jan 20, 2023 that may be closed by this pull request
@sr-gi
sr-gi requested a review from mariocynicys January 20, 2023 21:52
@sr-gi

sr-gi commented Jan 20, 2023

Copy link
Copy Markdown
Member Author

@jochemin @decentralizedb you may want to give this a look

@sr-gi sr-gi added Seeking Code Review review me pls easy to review easypeasy labels Jan 23, 2023
@sr-gi sr-gi added this to the 0.2 milestone Jan 23, 2023
@sr-gi

sr-gi commented Jan 23, 2023

Copy link
Copy Markdown
Member Author

Hey @jochemin @decentralizedb @lunaticoin, this is the only thing blocking v0.2.0, can you give it a try?

@decentralizedb

Copy link
Copy Markdown
Contributor

I tried this configuration, and it worked.
Just one comment, the lines:
After=bitcoind.service
After=network.target

It's equivalent to having:
After=network.target bitcoind.service

I suggest changing it because it's clearer to read putting both options on the same line.
For the rest, everything worked without any problem.

This builds on top of the work from the work by @decentralizedb and @jochemin.
It is mainly just re-arranging the code and readmes to fit the reviews.

Co-authored-by: decentralizedb <decentralized.b@protonmail.com>
Co-authored-by: jochemin <jochemin@gmail.com>
@sr-gi

sr-gi commented Jan 23, 2023

Copy link
Copy Markdown
Member Author

Addressed comments and rebased master

@sr-gi
sr-gi merged commit d386e56 into talaia-labs:master Jan 23, 2023
@sr-gi sr-gi mentioned this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add option to let teosd run as a background daemon

2 participants