fix: preserve CSV role/auth in createusers, fix case-sensitive validation#422
Open
jacalata wants to merge 1 commit into
Open
fix: preserve CSV role/auth in createusers, fix case-sensitive validation#422jacalata wants to merge 1 commit into
jacalata wants to merge 1 commit into
Conversation
…tion - createusers was replacing the fully-parsed user_obj with a bare TSC.UserItem(name), silently discarding site_role and auth_setting from the CSV (fixes #297) - _validate_item was case-sensitive against lowercase CHOICES values, rejecting valid inputs like "Viewer" or "Creator" (fixes #351) - Column.MAX was 7, blocking the 8th auth column; added AUTH=7, MAX=8 - Added auth column to CHOICES so validation passes it through to TSC Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createuserswas replacing the fully-parseduser_objwith a bareTSC.UserItem(name), silently discardingsite_roleandauth_settingfrom the CSV (fixes User import - license name is case sensitive still #297)_validate_itemwas case-sensitive against lowercaseCHOICESvalues, rejecting valid inputs likeViewerorCreator(fixes Createsiteusers CSV fails with error "'Invalid value for 3: Viewer'': ''''" #351)Column.MAXwas 7, blocking the 8th auth column; addedAUTH=7,MAX=8CHOICESso validation passes it through to TSCTest plan
test_validate_mixed_case_license— mixed-case license/admin/publisher values pass validationtest_parse_line_preserves_role— parsedsite_rolesurvives through toserver.users.add()🤖 Generated with Claude Code