Skip to content

fix: preserve CSV role/auth in createusers, fix case-sensitive validation#422

Open
jacalata wants to merge 1 commit into
developmentfrom
jac/fix-csv-user-import
Open

fix: preserve CSV role/auth in createusers, fix case-sensitive validation#422
jacalata wants to merge 1 commit into
developmentfrom
jac/fix-csv-user-import

Conversation

@jacalata

@jacalata jacalata commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • test_validate_mixed_case_license — mixed-case license/admin/publisher values pass validation
  • test_parse_line_preserves_role — parsed site_role survives through to server.users.add()

🤖 Generated with Claude Code

…tion

- createusers was replacing the fully-parsed user_obj with a bare
  TSC.UserItem(name), silently discarding site_role and auth_setting
  from the CSV (fixes #297)
- _validate_item was case-sensitive against lowercase CHOICES values,
  rejecting valid inputs like "Viewer" or "Creator" (fixes #351)
- Column.MAX was 7, blocking the 8th auth column; added AUTH=7, MAX=8
- Added auth column to CHOICES so validation passes it through to TSC

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py101010 0%
   _version.py111111 0%
   tabcmd.py151515 0%
   version.py955 44%
tabcmd/commands
   commands.py101010 0%
   constants.py771818 77%
   server.py1351818 87%
tabcmd/commands/auth
   session.py3814646 88%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1571818 89%
   datasources_workbooks_views_url_parser.py14255 96%
   delete_command.py601616 73%
   export_command.py1202525 79%
   get_url_command.py1274747 63%
   publish_command.py1232828 77%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481010 79%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2722 93%
   edit_site_command.py3822 95%
   list_command.py771212 84%
   list_sites_command.py2922 93%
tabcmd/commands/user
   add_users_command.py2955 83%
   create_site_users.py581111 81%
   create_users_command.py5999 85%
   delete_site_users_command.py4355 88%
   user_data.py2223131 86%
tabcmd/execution
   _version.py222 0%
   global_options.py12588 94%
   localize.py661111 83%
   logger_config.py5166 88%
   tabcmd_controller.py4277 83%
TOTAL284945284% 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant