push code for 2.11#229
Merged
Merged
Conversation
jacalata
commented
Feb 17, 2023
jacalata
commented
Contributor
- set user-agent
- fix filtering that uses a space in the filter parameter name
- handle failures in the session storage and recover
- implement --include-all, --datasources and url parameters for create/delete extracts
Unable to add a user to a group with tabcmd 2.0 if username contains uppercase
* handle exit with no logger * redact logging token, also clean up exit a little * add logging to check signin failure * remove duplicate log lines * refactor: extract strings to local dictionary to make it easier to extract to another file * add error handling around session file data * add flows and object detail to list output * some test coverage
* encoding filter values to handle spaces and special chars in filters * added new --filter option to pass in un-encoded value for simpler input * refactoring order of args, method names * stopped sending filters for workbooks
* add --url, --include-all/--embedded-datasources for create/refresh/delete extract commands * replace polling code with library call * add views to workbook listing
anyoung-tableau
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.