chore: fix clippy lints surfaced by Rust 1.97 toolchain bump#183
Merged
StefanSteiner merged 1 commit intoJul 9, 2026
Merged
Conversation
CI's pinned `stable` toolchain moved 1.95 -> 1.97 (2026-07-07), which tightened three lints on pre-existing test/code shared with main: - dead_code: tests/common/mod.rs helpers are compiled into every integration-test binary but each uses only a subset. Replace the scattered per-item #[expect]/#[allow] attributes (the struct's #[expect] was unfulfilled in binaries that DO use it) with one module-level #![allow(dead_code, reason=...)]. - useless_borrows_in_formatting: logging_tests.rs, 19x '&*logs' -> '*logs'. - manual_assert_eq: server_version.rs, assert!(a == b) -> assert_eq!(a, b). Verified green on both 1.95 and 1.97 with: cargo clippy --workspace --all-targets --all-features -- -D warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix three clippy lints that were tightened/added in the Rust 1.97 stable release (2026-07-07) and now fail CI under
-D warnings. All three are on pre-existing code — no behavior change.dead_codehyperdb-api/tests/common/mod.rs#[expect(dead_code)]/#[allow(dead_code)]attributes with a single module-level#![allow(dead_code, reason = ...)]. The shared helpers are compiled into every integration-test binary but each binary uses only a subset, so any given helper is dead in the binaries that don't reference it.allow(notexpect) because the same item is live in other binaries — anexpectwould be unfulfilled there and tripunfulfilled_lint_expectations. The struct's previous#[expect]was in fact already unfulfilled under 1.97.useless_borrows_in_formattinghyperdb-api/tests/logging_tests.rs(×19)&*logs→*logsinassert!format args.manual_assert_eqhyperdb-api/src/server_version.rs:265assert!(v1 == ...)→assert_eq!(v1, ...).Why now
The repo's
rust-toolchain.tomlpinschannel = "stable"— a moving target — and CI'sactions-rust-lang/setup-rust-toolchain@v1 { toolchain: stable }fetches the newest stable.main's last CI run predates the 1.95 → 1.97 bump, somaincurrently looks green but fails the moment CI re-runs on 1.97. Any open PR that triggers a fresh CI run (e.g. the open dependabot PRs) will hit this same wall until this lands.Verification
On the CI toolchain (
1.97.0) withHYPERD_PATHset, both CI commands are green:Also verified green on 1.95 (backward-compatible), and the affected tests pass:
server_version14/0,logging_tests8/0.