Conversation
Add vite-plugin-checker to dev dependencies and enable it in vite.config.ts (vueTsc: true) so Vite runs TypeScript/template checks during development. Update package.json and package-lock.json accordingly. Also remove an unused ClipboardDocumentIcon import from ProfileArea.vue.
Adjust contextmenu event modifiers in ProfileArea.vue to prevent menu conflicts: removed .self on the sidebar handler and added .stop.prevent to folder, profile and empty-state handlers so their right-click events don't bubble up to the sidebar. Ensures the correct context menu is shown depending on where the user right-clicks.
Update App.vue layout: change container alignment from items-start to items-stretch so grid children fill available height, and add bg-gray-50 and h-full to the left column wrapper to give the ProfileArea a full-height, light background. This improves visual consistency and ensures the sidebar spans the full viewport height.
Add Tailwind's `min-h-screen` utility to the left column wrapper so the ProfileArea spans the full viewport height. This fixes layout issues where the sidebar could be shorter than the page when content is limited; no functional changes beyond styling.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the sidebar's context menu handling, enhances the sidebar's visual structure, and adds type checking to the development workflow. The main changes are grouped below:
Developer Tooling Improvements:
vite-plugin-checkertodevDependenciesinpackage.jsonand configured it invite.config.tsto enable real-time TypeScript and template checking withvue-tsc. This helps catch type errors during development. [1] [2]Sidebar UI and UX Enhancements:
App.vueto usemin-h-screen h-fulland a consistentbg-gray-50background for improved layout and appearance.ProfileArea.vueby using.stop.preventmodifiers. This ensures context menus only open for the intended sidebar elements and do not propagate to parent elements, providing a more reliable user experience. [1] [2]Code Cleanup:
ClipboardDocumentIconimport fromProfileArea.vueto keep the codebase clean.