fix: deserialize OAS 3.1 scalar schema type into Set - #5266
Open
kalayciburak wants to merge 3 commits into
Open
Conversation
TypeSerializer writes a single type as a JSON string while the model field is Set<String>. Add a matching TypeDeserializer so JsonSchema JSON round-trips and convertValue keep a single type. Fixes swagger-api#5264
| @@ -42,6 +48,7 @@ public abstract class Schema31Mixin { | |||
|
|
|||
| @JsonProperty("type") | |||
| @JsonSerialize(using = TypeSerializer.class) | |||
Contributor
There was a problem hiding this comment.
Note that the serializer is used in an additional location and that it might be of relevance to attach the deserializer there as well.
Author
There was a problem hiding this comment.
yep, added TypeDeserializer on SortedSchemaMixin31 too
sortOutput replaces Schema31Mixin with SortedSchemaMixin31, so the scalar OAS 3.1 type deserializer needs to live on that mixin too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
OpenAPI 3.1 serializes a single schema
typeas a JSON string ("type":"integer") viaSchema31Mixin.TypeSerializer, while the model field isSet<String> types. Deserializing that scalar back intoJsonSchemafailed with:This adds a matching
TypeDeserializerthat accepts both the scalar form and the multi-type array form ("type":["string","null"]), so JSON round-trips andconvertValuekeep the type set.Fixes #5264
Type of Change
Checklist
Test plan
Executed: