always set accept/accept-language headers when making a self-request - #7722
Merged
Conversation
🦋 Changeset detectedLatest commit: d8b0b54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
Nov 19, 2022
Rich-Harris
pushed a commit
that referenced
this pull request
Jul 28, 2026
) #7722 added `accept-language` inheritance below the `authorization` inheritance without porting its null guard, so when the incoming request has no `Accept-Language` (requests made during prerendering never do), every internal sub-request gets the literal string `null`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7720. We previously decided not to automatically include request headers, but I think these exceptions are valid. Given that
acceptis used within Kit for content negotiation purposes, it makes sense to default it to*/*if unspecified. Similarly, ifaccept-languagewere to be used for i18n purposes, it makes sense for it to match the initial page request.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0