Skip to content

[fix] export HttpError/Redirect interface - #7701

Merged
Rich-Harris merged 1 commit into
masterfrom
error-redirect-interfaces
Nov 17, 2022
Merged

[fix] export HttpError/Redirect interface#7701
Rich-Harris merged 1 commit into
masterfrom
error-redirect-interfaces

Conversation

@dummdidumm

Copy link
Copy Markdown
Member

Fixes #7319
Also overall a more sensible approach; the function is public, so is their return type

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes #7319
Also overall a more sensible approach; the function is public, so is their return type
@changeset-bot

changeset-bot Bot commented Nov 17, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5f842c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Rich-Harris merged commit e822a0e into master Nov 17, 2022
@Rich-Harris
Rich-Harris deleted the error-redirect-interfaces branch November 17, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not find a declaration file for module '../src/runtime/control.js' error when typechecking svelte.config.js with noImplicitAny

2 participants